Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PWA features to support Add to Home Screen #243

Merged
merged 5 commits into from
Jul 5, 2022

Conversation

ThaUnknown
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[X] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)
[Hopefully] Added a working manifest and service worker to make the website installable as a PWA. This is a bare minimum, the service worker has no added functionality like caching etc.
Which issue (if any) does this pull request address?
#213

@welcome
Copy link

welcome bot commented Mar 11, 2021

🙌 Thanks for opening this pull request! You're awesome.

Copy link

@hello-smile6 hello-smile6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Just add the apple-mobile-web-app-capable meta tag, and this is ready to go!

@hello-smile6
Copy link

You'll need a separate icon for this. iOS does black for transparency.

static/sw.js Outdated Show resolved Hide resolved
Copy link
Member

@DiegoRBaquero DiegoRBaquero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a cool addition, want me to take over?

@DiegoRBaquero DiegoRBaquero changed the title Add PWA features to support Add to Home Screen feat: add PWA features to support Add to Home Screen Sep 17, 2021
static/manifest.json Outdated Show resolved Hide resolved
@ThaUnknown
Copy link
Member Author

This would be a cool addition, want me to take over?

I mean it's as basic as it gets really, you could add more features if you'd like to, but other than that it's pretty much done.

Copy link
Member

@alxhotel alxhotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alxhotel alxhotel merged commit 0e66038 into webtorrent:master Jul 5, 2022
@welcome
Copy link

welcome bot commented Jul 5, 2022

🎉 Congrats on getting your first pull request landed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants