-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add PWA features to support Add to Home Screen #243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good! Just add the apple-mobile-web-app-capable
meta tag, and this is ready to go!
You'll need a separate icon for this. iOS does black for transparency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a cool addition, want me to take over?
I mean it's as basic as it gets really, you could add more features if you'd like to, but other than that it's pretty much done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[X] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
[Hopefully] Added a working manifest and service worker to make the website installable as a PWA. This is a bare minimum, the service worker has no added functionality like caching etc.
Which issue (if any) does this pull request address?
#213