Add cross-platform fallbacks for memory and load checks - #68
Open
foxyManTou wants to merge 3 commits into
Open
Conversation
- check_memory_usage(): fallback chain: /proc/meminfo → psutil → sysctl - check_load_average(): fallback: /proc/loadavg → os.getloadavg() - _memory_usage_from_proc/_psutil/_sysctl helpers for clean separation - _format_memory_result shared formatter - Add test_health_check_fallbacks.py with unit tests for all fallback paths - Backward compatible: Linux /proc paths unchanged Fixes: the health check now returns meaningful values on macOS and other non-Linux environments instead of generic /proc read failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add cross-platform fallbacks for
check_memory_usage()andcheck_load_average()so the health check tool works on macOS and other non-Linux environments.Changes
check_memory_usage() — fallback chain:
/proc/meminfo(Linux, unchanged)psutil(cross-platform, if installed)sysctl(macOS/BSD)check_load_average() — fallback:
/proc/loadavg(Linux, unchanged)os.getloadavg()(POSIX — macOS, BSD, Linux)Testing
tools/test_health_check_fallbacks.pywith 6 unit tests covering all fallback pathsFixes: Health check now reports meaningful values on non-Linux systems.