test(parsers): add independent log parser fixtures and validation script [Fixes #5] - #87
Open
gianmarcozap wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Issue #5 — Adds independent parser fixtures for ools/log_aggregator.py that are hand-written from documented log format specifications, not generated by the parser code itself. This eliminates the 40%% false-pass rate noted in the TODO comment.
Fixture Source & Intent
All fixture files were authored by hand from:
No fixture was generated by running the parsers on sample data.
Files Added
Validation
\
$ python3 tests/test_parser_fixtures.py
=== JSON Log Parser Fixtures ===
=== Text Log Parser Fixtures ===
=== Nginx Log Parser Fixtures ===
=== Malformed / Unsupported Line Fixtures ===
RESULTS: 82 passed, 0 failed
All parser fixture validations passed!
\\
build.py Diagnostic
\�uild.py\ has a pre-existing SyntaxError (f-string backslash on line 662) that prevents generating the .logd\ artifact. This is unrelated to this PR's changes.
Acceptance Criteria Checklist
Payout address: 0xBd6B1B6118eC9D736EE1d5E476f86BCA1b3739f5