Fix HighMemoryUsage alert ratio - #22
Open
mirzakah wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #1. Fixes the recommended
HighMemoryUsagePrometheus alert so it no longer dividesprocess_resident_memory_bytesby itself. The rule now compares process resident memory tomachine_memory_bytesusingon(instance)vector matching while keeping the existing threshold and alert metadata.Changes
HighMemoryUsageexpression with a real memory usage ratio.diagnostic/build-8c3fd31c.jsonfrom the requiredpython3 build.pyrun.Testing
python3 tools/test_monitoring_setup_memory_alert.pypassed./Users/mirzakahrovic/Documents/codex-bounty-grinder/.venv/bin/python -m pytest tools/test_monitoring_setup_memory_alert.py -qpassed.python3 -m py_compile tools/monitoring_setup.py tools/test_monitoring_setup_memory_alert.pypassed.git diff --check HEAD~1..HEADpassed.python3 build.pyran and generateddiagnostic/build-8c3fd31c.json; 3/10 modules passed (frontend,market,v2-market-stream). The remaining failures are local toolchain/environment failures (cargo,cmake, Java runtime,luac,ghc) plus the existing macOSfrailboxMAP_HUGETLBcompile issue..logdcreation failed locally with encryptly errorb400a134ad13c8d7c8e3; the diagnostic JSON records this failure.Checklist
.logdcreation failed locally; diagnostic JSON is committed)