fix(tools): correct HighMemoryUsage PromQL ratio (#1) - #24
Open
yanyishuai wants to merge 1 commit into
Open
Conversation
Author
|
External bounty ready for maintainer review — acceptance criteria documented in PR body. Happy to address feedback immediately. |
yanyishuai
force-pushed
the
bounty/issue-1-high-memory-alert
branch
from
July 1, 2026 09:47
fc6aade to
b5f3d5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
HighMemoryUsagealert so it compares process resident memory againstmachine_memory_bytesinstead of dividingprocess_resident_memory_bytesby itself (which always evaluates to1).Changes
tools/monitoring_setup.py— corrected PromQL ratio +validate_alert_rules()guard for self-dividing expressionstools/tests/test_monitoring_alert_exprs.py— regression coverage for recommended rules and broken expressionsValidation
Dry-run alert upload behavior is unchanged aside from the corrected expression.
Closes #1
Solana wallet for bounty payout:
Do4v7foHJvRJLpRRoGaVPWX6DDEjX3yTK7J91gpwUQpE