fix: replace self-dividing HighMemoryUsage alert expression - #30
Open
pistakugli wants to merge 1 commit into
Open
fix: replace self-dividing HighMemoryUsage alert expression#30pistakugli wants to merge 1 commit into
pistakugli wants to merge 1 commit into
Conversation
The HighMemoryUsage alert was using process_resident_memory_bytes / process_resident_memory_bytes which always evaluates to 1. Replaced with process_resident_memory_bytes / machine_memory_bytes to compare against actual system memory. Added validation test to catch self-dividing alert expressions. Fixes weilixiong#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
HighMemoryUsagealert usedprocess_resident_memory_bytes / process_resident_memory_bytes > 0.9which is self-dividing and always evaluates to 1, making the alert unreliable.Solution
Replaced the self-dividing expression with
process_resident_memory_bytes / machine_memory_bytes > 0.9to compare against actual system memory.Changes
tools/monitoring_setup.py: Fixed the alert expressiontools/test_monitoring.py: Added validation test to catch self-dividing expressionsValidation
python3 tools/test_monitoring.py— PASSFixes #1
Wallet: 0xb7419c92b1d93251c0c85b756b390b29ab8162e0 (Polygon)