Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download all country maps & Use OSM instead of google maps for locations #220

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Download all country maps & Use OSM instead of google maps for locations #220

wants to merge 11 commits into from

Conversation

ToppAce
Copy link
Contributor

@ToppAce ToppAce commented Nov 19, 2020 •
edited
Loading

Beschreibung

closes #212:

  • create a script to download all maps from highcharts, so they don't have to be loaded on the run
  • download the maps
  • change the projects_map template

closes #216:

  • use easy_thumbnails to deal with partner logos

closes #197:

  • implement the widget of django-location-field to our existing field in the Location model. In this way no migration are necessary

Typ

Unzutreffendes bitte löschen

  • DSGVO
  • Neues Feature

@ToppAce ToppAce requested a review from bhemmer November 19, 2020 09:41
bhemmer
bhemmer reviewed Nov 22, 2020
View reviewed changes
Copy link
Member

@bhemmer bhemmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes/questions/comments.
I leave this PR open for @spuetz to merge and deploy.

wbcore/management/commands/download_country_maps.py Outdated Show resolved Hide resolved
wbcore/management/commands/download_country_maps.py Outdated Show resolved Hide resolved
wbcore/management/commands/download_country_maps.py Show resolved Hide resolved
weitblick/settings.py Outdated Show resolved Hide resolved
@ToppAce ToppAce changed the title Download all country maps Download all country maps & Use OSM instead of google maps for locations Dec 2, 2020
@bhemmer
Copy link
Member

bhemmer commented Jul 1, 2021

@ToppAce did we refer to the by licence by highmaps somewhere?

@ToppAce
Copy link
Contributor Author

ToppAce commented Jul 2, 2021

@ToppAce did we refer to the by licence by highmaps somewhere?

I added the attribution on the maps:
grafik

As it is a "Creative Commons (CC) Attribution-Noncommercial license" I guess this should be enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhemmer bhemmer bhemmer left review comments

Assignees

@spuetz spuetz

@bhemmer bhemmer

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ToppAce @bhemmer @spuetz