WELD-2755 Remove usage of ThreadGroup from Weld executors #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative approach to #2880 and a solution for WELD-2755 JIRA.
This should go hand in hand with WFLY changes, i.e. wildfly/wildfly#17193
We don't seem to leverage the
ThreadGroupin any way so having explicit groups serves no purpose.From the API, it is possible to just not define a group and roll with the default; note that we should do the same on WFLY side (
WeldExecutorServices) unless there is some other restriction in play that I am not aware of yet.