Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WELD-2762 Do not swallow exceptions occuring during HTTP session creation #2894

Merged
merged 1 commit into from
Oct 18, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,10 @@ protected HttpSession getSession(boolean create) {
try {
return SessionHolder.getSession(request, create);
} catch (IllegalStateException e) {
// If container can't create an underlying session, invalidate the
// current one
// If container can't create an underlying session, invalidate the current one
detach();
return null;
// re-throw the exception to properly show cause and message
throw e;
}
}

Expand Down
Loading