WELD-2786 OM configurator without overriden notify method should respect Reception settings

impl/src/main/java/org/jboss/weld/bootstrap/events/configurator/ObserverMethodConfiguratorImpl.java

@@ -40,6 +40,7 @@
 import jakarta.enterprise.inject.spi.ObserverMethod;
 import jakarta.enterprise.inject.spi.configurator.ObserverMethodConfigurator;
 
+import org.jboss.weld.event.ObserverMethodImpl;
 import org.jboss.weld.event.SyntheticObserverMethod;
 import org.jboss.weld.logging.EventLogger;
 import org.jboss.weld.resolution.CovariantTypes;
@@ -82,7 +83,11 @@ public ObserverMethodConfiguratorImpl(Extension extension) {
     public ObserverMethodConfiguratorImpl(ObserverMethod<T> observerMethod, Extension extension) {
         this(extension);
         read(observerMethod);
-        notifyWith(e -> observerMethod.notify(e));
+        if (observerMethod instanceof ObserverMethodImpl<?, ?>) {
+            notifyWith(e -> ((ObserverMethodImpl) observerMethod).notify(e.getEvent(), this.reception));
+        } else {
+            notifyWith(e -> observerMethod.notify(e));
+        }
     }
 
     @Override

impl/src/main/java/org/jboss/weld/event/ObserverMethodImpl.java

@@ -295,15 +295,23 @@ public void initialize(EnhancedAnnotatedMethod<T, ? super X> annotated) {
 
     @Override
     public void notify(final T event) {
-        sendEvent(event);
+        sendEvent(event, getReception());
+    }
+
+    /**
+     * Used as default notify method from ObserverMethodConfiguratorImpl.
+     * This allows Weld to respect {@link Reception} set in the configurator.
+     */
+    public void notify(final T event, Reception reception) {
+        sendEvent(event, reception);
     }
 
     /**
      * Invokes the observer method immediately passing the event.
      *
      * @param event The event to notify observer with
      */
-    protected void sendEvent(final T event) {
+    public void sendEvent(final T event, Reception reception) {
         if (isStatic) {
             sendEvent(event, null, null);
         } else {

tests-arquillian/src/test/java/org/jboss/weld/tests/observers/extension/configure/Foo.java

@@ -0,0 +1,5 @@
+package org.jboss.weld.tests.observers.extension.configure;
+
+// event payload
+public class Foo {
+}

tests-arquillian/src/test/java/org/jboss/weld/tests/observers/extension/configure/MyExtension.java

@@ -0,0 +1,13 @@
+package org.jboss.weld.tests.observers.extension.configure;
+
+import jakarta.enterprise.event.Observes;
+import jakarta.enterprise.event.Reception;
+import jakarta.enterprise.inject.spi.Extension;
+import jakarta.enterprise.inject.spi.ProcessObserverMethod;
+
+public class MyExtension implements Extension {
+
+    public void pom(@Observes ProcessObserverMethod<Foo, ObservingBean> pom) {
+        pom.configureObserverMethod().reception(Reception.IF_EXISTS);
+    }
+}

tests-arquillian/src/test/java/org/jboss/weld/tests/observers/extension/configure/ObserverReceptionConfigurationTest.java

@@ -0,0 +1,48 @@
+package org.jboss.weld.tests.observers.extension.configure;
+
+import jakarta.enterprise.event.Event;
+import jakarta.enterprise.inject.spi.Extension;
+import jakarta.inject.Inject;
+
+import org.jboss.arquillian.container.test.api.Deployment;
+import org.jboss.arquillian.junit.Arquillian;
+import org.jboss.shrinkwrap.api.BeanArchive;
+import org.jboss.shrinkwrap.api.ShrinkWrap;
+import org.jboss.shrinkwrap.api.spec.JavaArchive;
+import org.jboss.weld.test.util.Utils;
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+
+@RunWith(Arquillian.class)
+public class ObserverReceptionConfigurationTest {
+
+    @Deployment
+    public static JavaArchive getDeployment() {
+        return ShrinkWrap
+                .create(BeanArchive.class, Utils.getDeploymentNameAsHash(ObserverReceptionConfigurationTest.class))
+                .addPackage(ObserverReceptionConfigurationTest.class.getPackage())
+                .addAsServiceProvider(Extension.class, MyExtension.class);
+    }
+
+    @Inject
+    ObservingBean bean;
+
+    @Inject
+    Event<Foo> fooEvent;
+
+    @Test
+    public void testObserverReceptionChanged() {
+        // assert initial state
+        Assert.assertEquals(0, ObservingBean.timesObserved);
+
+        // fire event and assert again, should not be notified
+        fooEvent.fire(new Foo());
+        Assert.assertEquals(0, ObservingBean.timesObserved);
+
+        // trigger bean creation and repeat the test
+        bean.ping();
+        fooEvent.fire(new Foo());
+        Assert.assertEquals(1, ObservingBean.timesObserved);
+    }
+}

tests-arquillian/src/test/java/org/jboss/weld/tests/observers/extension/configure/ObservingBean.java

@@ -0,0 +1,18 @@
+package org.jboss.weld.tests.observers.extension.configure;
+
+import jakarta.enterprise.context.ApplicationScoped;
+import jakarta.enterprise.event.Observes;
+
+@ApplicationScoped
+public class ObservingBean {
+
+    public static int timesObserved = 0;
+
+    public void observe(@Observes Foo foo) {
+        timesObserved++;
+    }
+
+    public void ping() {
+        // no-op but forces bean init when invoked
+    }
+}