-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pb/update/non aws #2798
Draft
paul-butcher
wants to merge
18
commits into
main
Choose a base branch
from
pb/update/non_aws
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Pb/update/non aws #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Executed command: scalafmt --non-interactive
I think this is a bust. We'll need to update things in Scala-libs first. At that point, the original PR this comes from might just work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This updates the dependencies found in this Scala Steward PR: #2727
Builds on #2727 fail because of Scala 2.13, the addSbtPlugin calls in plugins.sbt all fail because the relevant 2.13 versions of the plugins cannot be found.
We should still endeavour to upgrade to 2.13, but this PR leaves it at 2.12 to isolate that upgrade from all the libraries.
How to test
Does it build? Does it run? Do the test pass?
How can we measure success?
I haven't looked at what, if any, benefits there are in any of these updates. My goal here is just to isolate the automated library updates from the scala one.
Success, therefore, is that the next time Scala Steward creates an update PR, it won't be as big as this one.
Have we considered potential risks?
Library updates can break things in. mysterious ways. We'll have to cross that. bridge when we come to it.