Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pb/update/non aws #2798

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Pb/update/non aws #2798

wants to merge 18 commits into from

Conversation

paul-butcher
Copy link
Contributor

What does this change?

This updates the dependencies found in this Scala Steward PR: #2727

Builds on #2727 fail because of Scala 2.13, the addSbtPlugin calls in plugins.sbt all fail because the relevant 2.13 versions of the plugins cannot be found.

We should still endeavour to upgrade to 2.13, but this PR leaves it at 2.12 to isolate that upgrade from all the libraries.

How to test

Does it build? Does it run? Do the test pass?

How can we measure success?

I haven't looked at what, if any, benefits there are in any of these updates. My goal here is just to isolate the automated library updates from the scala one.

Success, therefore, is that the next time Scala Steward creates an update PR, it won't be as big as this one.

Have we considered potential risks?

Library updates can break things in. mysterious ways. We'll have to cross that. bridge when we come to it.

@paul-butcher
Copy link
Contributor Author

I think this is a bust. We'll need to update things in Scala-libs first. At that point, the original PR this comes from might just work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant