Better property name (displayType -> highlightTourType)

wellcomecollection · Jan 9, 2025 · 727e9d1 · 727e9d1
1 parent f8d23b5
commit 727e9d1
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/pipeline/src/transformers/addressables/exhibitionHighlightTour.ts b/pipeline/src/transformers/addressables/exhibitionHighlightTour.ts
@@ -68,14 +68,18 @@ export const transformAddressableExhibitionHighlightTour = (
   const audio = {
     ...shared,
     id: `${id}/${type}/audio`,
-    display: { ...shared.display, displayType: 'audio', title: audioTitle },
+    display: {
+      ...shared.display,
+      highlightTourType: 'audio',
+      title: audioTitle,
+    },
     query: { ...shared.query, title: audioTitle, body: audioBody },
   };
 
   const bsl = {
     ...shared,
     id: `${id}/${type}/bsl`,
-    display: { ...shared.display, displayType: 'bsl', title: bslTitle },
+    display: { ...shared.display, highlightTourType: 'bsl', title: bslTitle },
     query: { ...shared.query, title: bslTitle, body: bslBody },
   };
 

diff --git a/pipeline/src/types/transformed/index.ts b/pipeline/src/types/transformed/index.ts
@@ -120,7 +120,10 @@ export type ElasticsearchAddressableExhibition =
   ElasticsearchAddressable<'Exhibition'>;
 
 export type ElasticsearchAddressableExhibitionHighlightTour =
-  ElasticsearchAddressable<'Exhibition highlight tour'>;
+  ElasticsearchAddressable<
+    'Exhibition highlight tour',
+    { highlightTourType: string }
+  >;
 
 export type ElasticsearchAddressableExhibitionText =
   ElasticsearchAddressable<'Exhibition text'>;

diff --git a/pipeline/test/transformers/__snapshots__/addressables.test.ts.snap b/pipeline/test/transformers/__snapshots__/addressables.test.ts.snap
@@ -120,7 +120,7 @@ exports[`addressables transformer transforms exhibition highlight tours from Pri
   {
     "display": {
       "description": "Showcasing Jason Wilsher-Mills’ largest and most personal commission to date, this exhibition is a joyful exploration of the body, drawing on the artist’s experience of becoming disabled as a child.",
-      "displayType": "audio",
+      "highlightTourType": "audio",
       "id": "ZthrZRIAACQALvCC",
       "title": "Jason and the Adventure of 254 audio highlight tour",
       "type": "Exhibition highlight tour",
@@ -240,7 +240,7 @@ exports[`addressables transformer transforms exhibition highlight tours from Pri
   {
     "display": {
       "description": "Showcasing Jason Wilsher-Mills’ largest and most personal commission to date, this exhibition is a joyful exploration of the body, drawing on the artist’s experience of becoming disabled as a child.",
-      "displayType": "bsl",
+      "highlightTourType": "bsl",
       "id": "ZthrZRIAACQALvCC",
       "title": "Jason and the Adventure of 254 British Sign Language tour",
       "type": "Exhibition highlight tour",