Add displayType to exhibition highlight tours #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we already have |
|
Tests all run well locally 👍 |
rcantin-w
approved these changes
Jan 9, 2025
format? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
For #195 – including an extra property in the
displayblock for exhibition-highlight-tours so that we can indicate whether it is about BSL or audio, and be able to link to the right place from the front end.How to test
cd pipeline && yarn test– tests pass (snapshot has been updated)How can we measure success?
Users understand what a search result is about and can be linked to the appropriate content from the search result
Have we considered potential risks?
n/a