Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audiences and format to transformer for query field. #197

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rcantin-w
Copy link
Contributor

@rcantin-w rcantin-w commented Jan 14, 2025

What does this change?

  • Adds audiences and format to events query object in transformer, as an array of string (audiences labels) and single string (format label).
  • Added them to the mapping
  • Added them to the query, kind of copied from what was done in articles. I suggest going ahead with that and amending should we think a change is needed.

How to test

Run api locally and search for http://localhost:3000/events?query=chill-out, which is a format that previously returned no results.

How can we measure success?

Results are more useful and more fields return results.

Have we considered potential risks?

Updating the mapping will be required before running a reindex. I've never done it but have tested locally and adding fields to the mapping should be straightforward.

@rcantin-w rcantin-w marked this pull request as ready for review January 15, 2025 16:51
@rcantin-w rcantin-w requested a review from a team as a code owner January 15, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant