-
Notifications
You must be signed in to change notification settings - Fork 1
DLCS Dependent Workflow #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tomcrane
wants to merge
44
commits into
main
Choose a base branch
from
dlcs-dependent-workflow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,784
−414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When base images are build MS support latest stable version of Debian at time of dotnet release, which is now bookworm
…_images Update to dotnet 8 base images
…collection/iiif-builder into dlcs-dependent-workflow
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
With the new Delivery Channels work, we rely on the DLCS named query manifest to tell us the exact sizes it has made for thumbnails.
But this means we can't build a IIIF Manifest until the DLCS batches have finished processing.
This PR changes the way Workflow Jobs are processed. If a workflow job has options (see RunnerOptions) that are dependent on the DLCS and ALSO has the
RunnerOptions.RegisterImages
option, the WorkflowProcessor starts the register images operation, marks the job as having running ingests (theIngestJobStarted
DateTime? field), removes theRunnerOptions.RegisterImages
option from the job, and keeps the job waiting to be picked up.The logic for picking a job up now requires that it can't have running DLCS ingests - that its
IngestJobStarted
field is null.A separate process polls the DLCS to see whether IngestJobStarted can be set to null.
We could go further - it's still possible to manually sync from the dashboard, which the workflow processor won't know about because there's no workflow job to be updated.
Problems:
WorkflowProcessor is now doing three related but distinct things:
IngestJobStarted
fieldWhile this PR can be released to see how this behaves, we should probably split these tasks into three independent services.
How to test
tbc
How can we measure success?
tbc
Have we considered potential risks?
Risks are that the workflow processor is doing too much work.
I also want to at least attempt to calculate the expected thumbnails from
w,
delivery channel policies and see whether they match, and report on this. If we find that we are 100% accurate in our predictions, we can toggle this behaviour off for the DDS specifically.