BSL icon changes #11597
Merged
BSL icon changes #11597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -844 B (-0.08%) Total Size: 1.02 MB
ℹ️ View Unchanged
|
rcantin-w
commented
Feb 11, 2025
| @@ -9,10 +9,14 @@ export function camelize(title: string): string { | |||
| const titleArray = title.toLowerCase().split(/-|_| /); | |||
|
|
|||
| return titleArray.reduce((acc, val, i) => { | |||
| const alphanumericVal = val.replace(/\W/g, ''); | |||
There was a problem hiding this comment.
this camelize function is used only as an id minter and in content/webapp/pages/events/[eventId]/index.tsx.
It made sense to me to remove non alphanumerical value for both these cases (otherwise it returned something like britishSignLanguage(online) instead of britishSignLanguageOnline.
| @@ -127,7 +127,8 @@ const getDescription = ({ | |||
| }; | |||
|
|
|||
| const eventInterpretationIcons: Record<string, IconSvg> = { | |||
| britishSignLanguage, | |||
| britishSignLanguageOnline: britishSignLanguageLive, | |||
| britishSignLanguage: britishSignLanguageLive, | |||
There was a problem hiding this comment.
Just checking these are both expected to be britishSignLanguageLive?
There was a problem hiding this comment.
YYYYYes I think it still makes sense. See the convo in ticket: #11516 (comment) let me know if you think it doesn't work out
davidpmccormick
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
#11516
Both the "British Sign Language" and "British Sign Language (online)" interpretation types are to display the hand icon:
http://localhost:3000/events/getting-started-with-research-at-wellcome-collection
http://localhost:3000/events/perspective-tour-with-anthony-manrique
There is currently no interpretation type to match the "BSL" icon, but it does get used in Exhibition Guides
How to test
How can we measure success?
Using the right, recognised icon for BSL across the site.
Have we considered potential risks?
Only used in a few places so all cases should've been addressed