Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add port redirection #23

Closed
wants to merge 1 commit into from
Closed

Conversation

ivyleavedtoadflax
Copy link
Contributor

Follows #21. Adds port redirect to the remote connect command.

To do this we probably need to do the following:

  • Use case when instead of if else for handling commands
  • Use case when for handling flags
  • Handle options, e.g.: -r|--redirect localhost:8080:8080

@ivyleavedtoadflax ivyleavedtoadflax self-assigned this Feb 25, 2021
@ivyleavedtoadflax
Copy link
Contributor Author

Might be easier to implement #14 rather than do this in bash...

@nsorros
Copy link
Contributor

nsorros commented Jul 21, 2021

Hey @ivyleavedtoadflax, could we get this into remote? What was the rational behind using case, do we need case for port redirection or we should split the case feature to another PR and implement port redirection first.

This is relevant for both prodigy and tensor board

@ivyleavedtoadflax
Copy link
Contributor Author

not sure...i had problems stacking options and flags, perhaps that is why i went for case

@ivyleavedtoadflax
Copy link
Contributor Author

Please save me and take this over @nsorros

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants