[opinionated] use Unicode Consortium file to generate guards. #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very opinionated approach to eliminate regular expressions at all.
Basically, I have the implementation partially stolen from Elixir core. It parses the Consortium Unicode spec files to produce
is_lowercase/1
andis_uppercase/1
guards alongside withcasing/1
function returning:upper | :lower | :not_a_letter
.Due to the parsing/clause generation stage, it compiles ≈20secs, but I consider it’s affordable because normally it happens only once per project/environment. Thanks to generated guards, the
Recase
methods work faster than the generic clause with~r/\p{Ll}\p{Lu}/
as we had in the previous version.