Skip to content

Commit

Permalink
Merge pull request #9676 from weseek/revert-9675-support/prepare-v1.0…
Browse files Browse the repository at this point in the history
….0-pdf-converter.0

support: Revert pdf converter implement
  • Loading branch information
yuki-takei authored Feb 23, 2025
2 parents 28679e1 + ab0ec06 commit a03bfad
Show file tree
Hide file tree
Showing 133 changed files with 562 additions and 8,122 deletions.
14 changes: 1 addition & 13 deletions .devcontainer/compose.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
services:
app:
node:
image: mcr.microsoft.com/devcontainers/base:ubuntu
volumes:
- ..:/workspace/growi:delegated
Expand All @@ -8,7 +8,6 @@ services:
- buildcache_app:/workspace/growi/apps/app/.next
- ../../growi-docker-compose:/workspace/growi-docker-compose:delegated
- ../../share:/workspace/share:delegated
- page_bulk_export_tmp:/tmp/page-bulk-export
tty: true
networks:
- default
Expand Down Expand Up @@ -45,21 +44,10 @@ services:
- /usr/share/elasticsearch/data
- ../../growi-docker-compose/elasticsearch/v8/config/elasticsearch.yml:/usr/share/elasticsearch/config/elasticsearch.yml

pdf-converter:
# enabling devcontainer 'features' was not working for secondary devcontainer (https://github.com/devcontainers/features/issues/1175)
image: mcr.microsoft.com/vscode/devcontainers/javascript-node:1-20
volumes:
- ..:/workspace/growi:delegated
- pnpm-store:/workspace/growi/.pnpm-store
- node_modules:/workspace/growi/node_modules
- page_bulk_export_tmp:/tmp/page-bulk-export
tty: true

volumes:
pnpm-store:
node_modules:
buildcache_app:
page_bulk_export_tmp:

networks:
default:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
// README at: https://github.com/devcontainers/templates/tree/main/src/ubuntu
{
"name": "GROWI-Dev",
"dockerComposeFile": "../compose.yml",
"service": "app",
"dockerComposeFile": "compose.yml",
"service": "node",
"workspaceFolder": "/workspace/growi",

"features": {
Expand All @@ -16,7 +16,7 @@
// "forwardPorts": [],

// Use 'postCreateCommand' to run commands after the container is created.
"postCreateCommand": "/bin/bash ./.devcontainer/app/postCreateCommand.sh",
"postCreateCommand": "/bin/bash ./.devcontainer/postCreateCommand.sh",

// Configure tool-specific properties.
"customizations": {
Expand All @@ -37,10 +37,7 @@
"vitest.explorer",
"ms-playwright.playwright"
],
"settings": {
"terminal.integrated.defaultProfile.linux": "bash"
}
},
}
},

// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
Expand Down
29 changes: 0 additions & 29 deletions .devcontainer/pdf-converter/devcontainer.json

This file was deleted.

17 changes: 0 additions & 17 deletions .devcontainer/pdf-converter/postCreateCommand.sh

This file was deleted.

File renamed without changes.
168 changes: 0 additions & 168 deletions .github/workflows/ci-pdf-converter.yml

This file was deleted.

Loading

0 comments on commit a03bfad

Please sign in to comment.