imprv: design of scrollbar in sidebar #8512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-takei
requested changes
Feb 29, 2024
| } from '~/stores/ui'; | ||
|
|
||
| import { DrawerToggler } from '../Common/DrawerToggler'; | ||
| import { StickyStretchableScroller } from '../StickyStretchableScroller'; |
There was a problem hiding this comment.
v6 で実装していたこの複雑すぎるコンポーネントはここでは必要ない(navbar がなくなったことで、高さを自動計算する必要がなくなった)
simplebar-react を使ってください
追加するコードもここまで大仰にはならないはず
yuki-takei
requested changes
Mar 15, 2024
| style={{ maxHeight: simplebarMaxHeight }} | ||
| > | ||
| <SidebarContents /> | ||
| </SimpleBar> |
There was a problem hiding this comment.
maxHeight の計算必要なのか？
simplebar-react の example を見るに、ref を指定して自動計算させることは可能に見える
|
reg-suit detected visual differences. Check this report, and review them. 🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴 What do the circles mean?The number of circles represent the number of changed images.🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items How can I change the check status?If reviewers approve this PR, the reg context status will be green automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
タスク
https://redmine.weseek.co.jp/issues/141061
概要
サイドバー内のスクロールバーがブラウザデフォルトのものになってしまっていたので、専用のスクロールバー（v6と同じもの）に置き換えた。
変更点
screen shot
セルフチェック