-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable restarting bulk export #9020
enable restarting bulk export #9020
Conversation
|
<button className="btn btn-primary" type="button" onClick={() => startBulkExport(PageBulkExportFormat.md)}> | ||
{t('page_export.markdown')} | ||
</button> | ||
<button className="btn btn-primary ms-2" type="button" onClick={() => startBulkExport(PageBulkExportFormat.pdf)}>PDF</button> | ||
{/* TODO: enable in https://redmine.weseek.co.jp/issues/135772 */} | ||
{/* <button className="btn btn-primary ms-2" type="button" onClick={() => startBulkExport(PageBulkExportFormat.pdf)}>PDF</button> */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pdf 形式は一旦リリースを見送るため、選択肢をコメントアウト
…nto feat/150418-151978-enable-restarting-bulk-export
…nto feat/150418-151978-enable-restarting-bulk-export
…nto feat/150418-151978-enable-restarting-bulk-export
…nto feat/150418-151978-enable-restarting-bulk-export
else if (err instanceof BulkExportJobRestartedError) { | ||
logger.info(err.message); | ||
await this.cleanUpExportJobResources(pageBulkExportJob); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BulkExportJobRestartedError の場合は cleanup をするだけで、通知はしない。
const errorCode = e?.[0].code ?? 'page_export.failed_to_export'; | ||
toastError(t(errorCode)); | ||
if (errorCode === 'page_export.duplicate_bulk_export_job_error') { | ||
setIsRestartModalOpened(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
重複している job の情報の一部をエラーに追加し、それをモーダルに追加表示させよう。
そうすることでユーザーが中断すべきかどうかを判断しやすくなると思う。
(以下一例)
- 作成日時
- トリガーしたユーザー
- その他表示した方がいい情報があれば
後続タスクでもよい
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
後続タスクで実装しますm(_ _)m
https://redmine.weseek.co.jp/issues/153064
restart までの実行内容
task
https://redmine.weseek.co.jp/issues/151978
screenshot