Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Lint Error #9021

Merged
merged 4 commits into from
Aug 9, 2024
Merged

fix: Lint Error #9021

merged 4 commits into from
Aug 9, 2024

Conversation

miya
Copy link
Member

@miya miya commented Aug 8, 2024

Task

  • #142089 [v7] 文字数の多いページ(Draw.ioなど)の Edit 画面開くと Markdown の内容が表示されない件の修正
    • #152245 151113, 148852 で出た lint error の修正

発生源の PR

Copy link

changeset-bot bot commented Aug 8, 2024

⚠️ No Changeset found

Latest commit: 94dff9e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -0,0 +1,3 @@
declare module 'emoji-mart';
declare module '@emoji-mart/data';
declare module '@emoji-mart/react';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@growi/editor/dist ではなく '@growi/editor/src からモジュールをインポートしていたことが原因でしたのでこちらの差分は消しました

@miya miya self-assigned this Aug 9, 2024
@miya miya requested a review from yuki-takei August 9, 2024 08:02
import type { AcceptedUploadFileType } from '@growi/core';
import type { ReactCodeMirrorProps } from '@uiw/react-codemirror';

import type { EditorSettings } from 'src/consts';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この行が ❌

@miya miya merged commit ae0e9c0 into feat/non-yjs-mode Aug 9, 2024
5 checks passed
@miya miya deleted the fix/152245-lint-error branch August 9, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants