Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add-announcement-to-dropdown #9671

Open
wants to merge 5 commits into
base: feat/announcement-function
Choose a base branch
from
Open

feat: add-announcement-to-dropdown #9671

wants to merge 5 commits into from
+19 −6

Conversation

Ryosei-Fukushima
Copy link
Contributor

@Ryosei-Fukushima Ryosei-Fukushima commented Feb 21, 2025 •
edited
Loading

https://redmine.weseek.co.jp/issues/161299

  1. アナウンスしたいページに飛ぶ
  2. ３点リーダーアイコンを押す

dropdownにannounceを追加
スクリーンショット 2025-02-18 182232

スクリーンショット 2025-02-18 182629

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 02453eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Ryosei-Fukushima Ryosei-Fukushima changed the title feat/add-announcement-to-dropdown feat:add-announcement-to-dropdown Feb 21, 2025
@Ryosei-Fukushima Ryosei-Fukushima changed the title feat:add-announcement-to-dropdown feat: add-announcement-to-dropdown Feb 21, 2025
@miya miya requested review from miya and yuki-takei February 25, 2025 05:00
miya
miya requested changes Feb 25, 2025
View reviewed changes
apps/app/src/client/components/Navbar/GrowiContextualSubNavigation.tsx Outdated
<span className="material-symbols-outlined me-1 grw-page-control-dropdown-icon">campaign</span>
{t('Announce')}
</DropdownItem>

Copy link
Member

@miya miya Feb 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figma と実装のデザインを見比べてみるとアナウンスの DropdownItem を入れる位置が間違ってそうなので修正してください。

スクリーンショット 2025-02-25 13 58 19

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正したのですが、PageItemControl.tsxに直書きするのではなく、src/features/announcement/client/componentsに新しくファイルを作り、コンポーネント化して開発するべきですかね？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miya miya miya requested changes

@yuki-takei yuki-takei Awaiting requested review from yuki-takei

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ryosei-Fukushima @miya