fix: fail at session() initialization when account is missing#240
Merged
brendanjryan merged 1 commit intomainfrom Mar 25, 2026
Merged
fix: fail at session() initialization when account is missing#240brendanjryan merged 1 commit intomainfrom
brendanjryan merged 1 commit intomainfrom
Conversation
commit: |
brendanjryan
force-pushed
the
brendanryan/session-require-account
branch
2 times, most recently
from
7891d04 to
c49808c
Compare
brendanjryan
changed the title
account required for server-side session()
brendanjryan
force-pushed
the
brendanryan/session-require-account
branch
from
c49808c to
d04d086
Compare
brendanjryan
changed the title
brendanjryan
force-pushed
the
brendanryan/session-require-account
branch
from
d04d086 to
e968e0f
Compare
brendanjryan
force-pushed
the
brendanryan/session-require-account
branch
from
e968e0f to
78ce862
Compare
tempo.session() now throws immediately at construction if no viem Account is provided, rather than waiting for a channel close to fail with an opaque error. The error message includes an example fix. Also improves the closeOnChain error message for clarity.
brendanjryan
force-pushed
the
brendanryan/session-require-account
branch
from
78ce862 to
1bfed6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
tempo.session()is configured without a viemAccount, the server starts up fine but fails later with an opaque error during a channel close request:Fix
Now
session()throws immediately at initialization with a clear, actionable message:Companion docs PR: tempoxyz/mpp#460