Merge pull request #3277 from wevote/develop

Bringing over all changes from develop since 2016.

.eslintignore

@@ -1,2 +1,3 @@
 src/js/vendor/*.js
-src/js/mock-data/
+src/js/mock-data/
+src/js/dispatcher/Dispatcher.js

.eslintrc

@@ -1,212 +1,80 @@
 {
   "parser": "babel-eslint",
+  "parserOptions": {
+    "sourceType": "module"
+  },
 
   "env": {
     "browser": true,
     "node": true,
     "es6": true
   },
 
-  "ecmaFeatures": {
-    "arrowFunctions": true,
-    "binaryLiterals": true,
-    "blockBindings": true,
-    "classes": false,
-    "defaultParams": true,
-    "destructuring": true,
-    "forOf": true,
-    "generators": true,
-    "modules": true,
-    "objectLiteralComputedProperties": true,
-    "objectLiteralDuplicateProperties": true,
-    "objectLiteralShorthandMethods": true,
-    "objectLiteralShorthandProperties": true,
-    "octalLiterals": true,
-    "regexUFlag": true,
-    "regexYFlag": true,
-    "spread": true,
-    "superInFunctions": false,
-    "templateStrings": true,
-    "unicodeCodePointEscapes": true,
-    "globalReturn": true,
-    "jsx": true
-  },
+  "extends": "airbnb",
 
   "rules": {
-    "block-scoped-var": [0],
-    "brace-style": [2, "1tbs", {"allowSingleLine": true}],
-    "camelcase": [0],
-    "comma-dangle": [0],
-    "comma-spacing": [1],
-    "comma-style": [2, "last"],
-    "complexity": [0, 11],
-    "consistent-return": [1],
-    "consistent-this": [0, "that"],
-    "curly": [0, "multi-line"],
-    "default-case": [1],
-    "dot-notation": [2, {"allowKeywords": true}],
-    "eol-last": [1],
-    "eqeqeq": [1],
-    "func-names": [0],
-    "func-style": [0, "declaration"],
-    "generator-star-spacing": [2, "after"],
-    "guard-for-in": [0],
-    "handle-callback-err": [0],
-    "key-spacing": [1, {"beforeColon": false, "afterColon": true}],
-    "quotes": [1, "double", "avoid-escape"],
-    "max-depth": [0, 4],
+    "array-bracket-spacing": [1, "never"],
+    "camelcase": [1],
+    "class-methods-use-this": 0,                  // We want to allow helper functions that don't use 'this' in classes
+    "jsx-a11y/alt-text": 0,
+    "jsx-a11y/anchor-has-content": 1,
+    "jsx-a11y/anchor-is-valid": 1,
+    "jsx-a11y/click-events-have-key-events": 0,
+    "jsx-a11y/heading-has-content": 1,
+    "jsx-a11y/iframe-has-title": 1,
+    "jsx-a11y/label-has-associated-control": 1,
+    "jsx-a11y/label-has-for": 0,                  // Deprecated in favor of 'label-has-associated-control'
+    "jsx-a11y/mouse-events-have-key-events": 1,
+    "jsx-a11y/no-autofocus": 1,
+    "jsx-a11y/no-noninteractive-element-interactions": 1,
+    "jsx-a11y/no-static-element-interactions": 0,
+    "jsx-quotes": 2,
     "max-len": [0, 80, 4],
-    "max-nested-callbacks": [0, 2],
-    "max-params": [0, 3],
-    "max-statements": [0, 10],
-    "new-parens": [2],
-    "new-cap": [0],
-    "newline-after-var": [0],
-    "no-alert": [2],
-    "no-array-constructor": [2],
-    "no-bitwise": [0],
-    "no-caller": [2],
-    "no-catch-shadow": [2],
-    "no-cond-assign": [2],
     "no-console": [0],
-    "no-constant-condition": [1],
-    "no-continue": [2],
-    "no-control-regex": [2],
-    "no-debugger": [2],
-    "no-delete-var": [2],
-    "no-div-regex": [0],
-    "no-dupe-args": [2],
-    "no-dupe-keys": [2],
-    "no-duplicate-case": [2],
     "no-else-return": [0],
-    "no-empty": [2],
-    "no-empty-character-class": [2],
-    "no-empty-label": [2],
-    "no-eq-null": [0],
-    "no-eval": [2],
-    "no-ex-assign": [2],
-    "no-extend-native": [1],
-    "no-extra-bind": [1],
-    "no-extra-boolean-cast": [2],
-    "no-extra-semi": [1],
-    "no-fallthrough": [2],
-    "no-floating-decimal": [2],
-    "no-func-assign": [2],
-    "no-implied-eval": [2],
-    "no-inline-comments": [0],
-    "no-inner-declarations": [2, "functions"],
-    "no-invalid-regexp": [2],
-    "no-irregular-whitespace": [2],
-    "no-iterator": [2],
-    "no-label-var": [2],
-    "no-labels": [2],
-    "no-lone-blocks": [2],
-    "no-lonely-if": [1],
-    "no-loop-func": [1],
-    "no-mixed-requires": [0, false],
-    "no-mixed-spaces-and-tabs": [2, false],
-    "no-multi-spaces": [1],
-    "no-multi-str": [2],
-    "no-multiple-empty-lines": [2, {"max": 2}],
-    "no-native-reassign": [1],
-    "no-negated-in-lhs": [2],
-    "no-nested-ternary": [0],
-    "no-new": [2],
-    "no-new-func": [2],
-    "no-new-object": [2],
-    "no-new-require": [0],
-    "no-new-wrappers": [2],
-    "no-obj-calls": [2],
-    "no-octal": [2],
-    "no-octal-escape": [2],
-    "no-param-reassign": [1],
-    "no-path-concat": [0],
+    "no-multi-spaces": [0],
+    "no-multiple-empty-lines": [0],               // allow indented comments (like this one)
     "no-plusplus": [0],
-    "no-process-env": [0],
-    "no-process-exit": [2],
-    "no-proto": [2],
-    "no-redeclare": [1],
-    "no-regex-spaces": [2],
-    "no-reserved-keys": [0],
-    "no-restricted-modules": [0],
-    "no-return-assign": [2],
-    "no-script-url": [2],
-    "no-self-compare": [0],
-    "no-sequences": [1],
-    "no-shadow": [1],
-    "no-shadow-restricted-names": [2],
-    "no-spaced-func": [1],
-    "no-sparse-arrays": [2],
-    "no-sync": [0],
-    "no-ternary": [0],
-    "no-throw-literal": [2],
-    "no-trailing-spaces": [1],
-    "no-undef": [1],
-    "no-undef-init": [2],
-    "no-undefined": [0],
     "no-underscore-dangle": [0],
-    "no-unreachable": [2],
-    "no-unused-expressions": [1],
-    "no-unused-vars": [1],
-    "no-use-before-define": [1],
-    "no-void": [0],
-    "no-warning-comments": [0, {"terms": ["todo", "fixme", "xxx"], "location": "start"}],
-    "no-with": [2],
-    "no-extra-parens": [1],
-    "one-var": [1, "never"],
-    "operator-assignment": [0, "always"],
-    "operator-linebreak": [1, "after"],
-    "padded-blocks": [0],
-    "quote-props": [0],
-    "radix": [0],
-    "semi": [1],
-    "semi-spacing": [2, {"before": false, "after": true}],
-    "sort-vars": [0],
-    "space-after-keywords": [2, "always"],
-    "space-before-function-paren": [1, {"anonymous": "always", "named": "always"}],
-    "space-before-blocks": [0, "always"],
-    "space-in-brackets": [
-      0, "never", {
-        "singleValue": true,
-        "arraysInArrays": false,
+    "object-curly-newline": 0,
+    "object-curly-spacing": [1,
+      "always", {
         "arraysInObjects": false,
-        "objectsInArrays": true,
-        "objectsInObjects": true,
-        "propertyName": false
+        "objectsInObjects": true
       }
     ],
-    "space-in-parens": [0],
-    "space-infix-ops": [1],
-    "space-return-throw-case": [2],
-    "space-unary-ops": [0, {"words": true, "nonwords": false}],
-    "spaced-line-comment": [0, "always"],
-    "strict": [0, "never"],
-    "use-isnan": [2],
-    "valid-jsdoc": [0],
-    "valid-typeof": [2],
-    "vars-on-top": [0],
-    "wrap-iife": [2],
-    "wrap-regex": [1],
-    "yoda": [2, "never", {"exceptRange": true}],
-    "react/jsx-boolean-value": 2,
-    "react/jsx-no-undef": 2,
-    "react/jsx-sort-props": 0,
-    "react/jsx-sort-prop-types": 0,
-    "react/jsx-uses-react": 2,
-    "react/jsx-uses-vars": 2,
+    "operator-linebreak": [1, "after"],
+    "padded-blocks": [1],
+    "prefer-destructuring": 1,
+    "quotes": [1, "single", "avoid-escape"],
+    "radix": 0,                                   // Dec 2018: We always use base 10, so specifying it each time seems excessive
+    "react/button-has-type": 1,
+    "react/destructuring-assignment": 0,          // Dec 2018: We should do this!  But right now we have 3990 warnings/errors if enabled.
+    "react/forbid-prop-types": 0,                 // Dec 2018: Should consider someday
+    "react/indent-prop": 0,
+    "react/jsx-first-prop-new-line": 0,
+    "react/jsx-indent-props": 0,
+    "react/jsx-no-bind": 1,                       // Dec 2018: Should these be errors?
+    "react/no-access-state-in-setstate": 1,
+    "react/no-array-index-key": 1,
+    "react/no-children-prop": 1,
     "react/no-did-mount-set-state": 0,
-    "react/no-did-update-set-state": 2,
-    "react/no-multi-comp": 2,
-    "react/no-unknown-property": 1,
+    "react/no-did-update-set-state": 0,
+    "react/no-string-refs": 1,
+    "react/no-unused-prop-types": 1,
+    "react/no-unused-state": 1,
+    "react/prefer-stateless-function": 0,
     "react/prop-types": 1,
-    "react/react-in-jsx-scope": 2,
-    "react/self-closing-comp": 2,
-    "jsx-quotes": 2,
+    "react/require-default-props": 0,              // Dec 2018: Might have value someday
+    "react/sort-comp": 1,
+    "react-hooks/rules-of-hooks": "error",         // Checks rules of Hooks
+    "react-hooks/exhaustive-deps": "warn",         // Checks effect dependencies
+    "space-before-function-paren": [1, {"anonymous": "always", "named": "always"}],
+    "space-in-parens": [1],
+    "template-curly-spacing": ["warn", "never"]
   },
     "plugins": [
-        "react"
-    ],
-    "global": {
-      "React": true
-    }
+      "react",
+      "react-hooks"
+    ]
 }

.github/ISSUE_TEMPLATE.md

@@ -0,0 +1,3 @@
+### Please describe the issue (What happens? What do you expect?)
+
+### Steps to reproduce the problem (1, 2, 3...), including links

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,3 @@
+### What github.com/wevote/WebApp/issues does this fix?
+
+### Changes included this pull request?

.gitignore

@@ -3,6 +3,8 @@
 
 # Ignore build files
 build
+build-live
+package-lock.json
 
 # TernJS
 ###################
@@ -24,10 +26,6 @@ pids
 ###################
 lib-cov
 
-# Coverage directory used by tools like istanbul
-###################
-coverage
-
 # Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
 ###################
 .grunt
@@ -60,13 +58,8 @@ venv
 *.class
 *.dll
 *.exe
-*.o
 *.so
 
-
-
-
-
 # PyInstaller #
 #  Usually these files are written by a python script from a template
 #  before PyInstaller builds the exe, so as to inject date/other infos into it.
@@ -109,11 +102,8 @@ target/
 # git has its own built in compression methods
 *.7z
 *.dmg
-*.gz
 *.iso
-*.jar
 *.rar
-*.tar
 *.zip
 
 # OS generated files #
@@ -152,24 +142,39 @@ sftp-config.json
 
 # Vim / emacs #
 ###############
-*~
-*#
 *.swp
 *.swo
 
 # Compass / Sass #
 ##################
 .sass-cache
 
+# Heroku Related #
+##################
+staticfiles
+
 # Other #
 #########
 /geo/data/
 /**/migrations/*.py
 !/**/migrations/__init__.py
-config/environment_variables.json
+src/js/config.js
+src/js/config-qa.js
+src/js/config-www.js
+tests/browserstack/browserstack.config.js
+src/javascript/google-tag-manager.js
+src/javascript/google-tag-manager-qa.js
+src/javascript/google-tag-manager-www.js
+src/javascript/google-analytics.js
+src/javascript/google-analytics-qa.js
+src/javascript/google-analytics-www.js
 web_app/build/*
+*.crt
+*.key
+.vscode
+.gitattributes
+/yarn.lock
+server.csr
+tests/browserstack/wdio.conf.js
+tests/browserstack/wdio.conf.template
 
-# Heroku Related #
-##################
-*.pyc
-staticfiles

.jscsrc

@@ -1,5 +1,11 @@
 {
     "preset": "airbnb",
     "validateQuoteMarks": null,
-    "excludeFiles": ["build/**", "node_modules"]
+    "excludeFiles": ["build/**", "node_modules"],
+    "maximumLineLength": null,
+    "maxErrors": 200,
+    "disallowSpacesInFunctionDeclaration": null,
+    "requirePaddingNewLinesBeforeLineComments": null,
+    "requirePaddingNewLinesAfterBlocks": null,
+    "disallowMultipleLineBreaks": null
 }