feature(admin): supabase 연결 및 설문 생성 로직 작성 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ssoon-m
changed the title
kickbelldev
approved these changes
Mar 3, 2024
| @@ -47,5 +47,12 @@ | |||
| } | |||
| } | |||
| }, | |||
| "nxCloudAccessToken": "ZjgyN2VmY2EtZjljMy00NGNiLTllMGUtMWI3OGQ2ZDAxN2M3fHJlYWQtd3JpdGU=" | |||
| "nxCloudAccessToken": "ZjgyN2VmY2EtZjljMy00NGNiLTllMGUtMWI3OGQ2ZDAxN2M3fHJlYWQtd3JpdGU=", | |||
There was a problem hiding this comment.
배포할 프로젝트가 아니면 크게 상관은 없는거 같습니당
kickbelldev
reviewed
Mar 3, 2024
| export const SupabaseContext = createContext<SupabaseContextValue | null>(null); | ||
| SupabaseContext.displayName = 'SupabaseContext'; | ||
|
|
||
| export const SupabaseProvider = ({ |
There was a problem hiding this comment.
web,admin 프로젝트에서 supabase 인스턴스 얻는 코드를 공통으로 사용하고 싶어서 묶었습니다!
leeyun1533
reviewed
Mar 3, 2024
| return <div>Admin!!</div>; | ||
| const mutate = useCreateSurvey(); | ||
|
|
||
| const onMutateSurvey = () => { |
There was a problem hiding this comment.
p4: 직접 연결되는 컴포넌트 네이밍은 handle-
props로 넘길때는 on- 각각 접두사를 사용하면 이후 명확하게 알 수 있어요
| hasOption: boolean; | ||
| }[] = []; | ||
|
|
||
| sectionIds.forEach((id, i) => { |
There was a problem hiding this comment.
p3: forEach가 아니라 map으로 함수를 반환하게 사용할 수 없을까요? 사소하지만 함수형으로 사용하도록 노력하면 명시적으로 작성할 수 있을 것 같아요
| @@ -8,6 +9,8 @@ const root = ReactDOM.createRoot( | |||
| ); | |||
| root.render( | |||
| <StrictMode> | |||
| <App /> | |||
| <SupabaseProvider supabaseKey={import.meta.env.VITE_SUPABASE_KEY}> | |||
| <App /> | |||
There was a problem hiding this comment.
p3: 가장 최상단에서 ErrorBoundary로 묶어서 처리하면 이후 에러가 전파되는 상황에서 에러를 처리하기가 좋습니닷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업한 내용