feature(admin): survey를 위한 viewmodel 작업 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeyun1533
reviewed
Mar 3, 2024
| @@ -0,0 +1,41 @@ | |||
| import { vars } from '@ssoon-servey/shared-ui'; | |||
There was a problem hiding this comment.
p3: 여기 hook으로 빼서 사용하시는 것 좋은 것 같아요
validation 처리도 있으면 좋을 것 같은데요, 지금 훅에서는 validation을 통한 에러처리는 결합되지 않은 것 같아서 이부분도 같이 챙겨볼 수 있을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업한 내용