feature(web): survey데이터 호출 #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeyun1533
reviewed
Mar 3, 2024
Comment on lines
+97
to
+105
| getSurvey(supabase) | ||
| .then((data) => { | ||
| setData(data); | ||
| setIsLoading(false); | ||
| }) | ||
| .catch(() => { | ||
| setIsError(true); | ||
| setIsLoading(false); | ||
| }); |
There was a problem hiding this comment.
p2: getSurvey는 async await을 사용하신반면, 여기는 Promise를 사용하셨는데요 통일하는게 좋지 않을까요?
그리고, useQuery에서 getSurvey를 불러오게도 사용하실 수 있을 것 같아요 react-query를 사용하시면 에러처리를 suspense로 할 수 있는등의 이점이 있습니다
Comment on lines
+20
to
+26
| if (isError) { | ||
| return <div>error</div>; | ||
| } | ||
|
|
||
| if (isLoading) { | ||
| return <div>loading...</div>; | ||
| } |
There was a problem hiding this comment.
p2: https://tech.kakaopay.com/post/react-query-2/ 여기 부분들도 Suspense도입과 에러처리 같이 해주시고,
추가로 Sentry 도입도 같이되어서 에러추적할 수 있게 설계해보시면 좋을 것 같습니다
|
요 PR에서 언급된 Suspense와 Errorboundary는 이해하고 도입 꼭 해주세요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업한 내용