Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements to the /wattsi endpoint #86

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

domenic
Copy link
Member

@domenic domenic commented Aug 31, 2023

In the course of working on adding a full /html-build endpoint, a few improvements came up which we can apply ahead of time to just the /wattsi endpoint:

  • Improve README documentation.
  • Abstract out the code for turning query parameters into boolean arguments.
  • Use more modern JS features.
  • Put temporary directories inside the OS temp directory.
  • Add a new helper for spawning a command-line program while capturing its output. This fixes output.txt should contain interleaved stdout/stderr instead of stdout + \n\n + stderr #3.
  • Perform cleanup file deletions in parallel and log errors if they occur while deleting.
  • Move from deprecated --production npm install argument to modern --omit=dev.

In the course of working on adding a full /html-build endpoint, a few improvements came up which we can apply ahead of time to just the /wattsi endpoint:

* Improve README documentation.
* Abstract out the code for turning query parameters into boolean arguments.
* Use more modern JS features.
* Put temporary directories inside the OS temp directory.
* Add a new helper for spawning a command-line program while capturing its output. This fixes #3.
* Perform cleanup file deletions in parallel and log errors if they occur while deleting.
* Move from deprecated --production npm install argument to modern --omit=dev.
@domenic domenic merged commit 1d40f95 into main Aug 31, 2023
2 checks passed
@domenic domenic deleted the wattsi-small-updates branch August 31, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

output.txt should contain interleaved stdout/stderr instead of stdout + \n\n + stderr
1 participant