Allow setting a maxAge

[aamuley]

Add maxAge as a CookieInitOption used in cookieStore.set(options).
Related to #57 #162

• At least two implementers are interested (and none opposed):
  • Chrome
  • WebKit
• Tests are written and can be reviewed and commented upon at:
  • web-platform-tests/wpt@0f2fc46
• Implementation bugs are filed:
  • Chromium: issue
  • Gecko: bug
  • WebKit: bug
• MDN issue is filed: Add max-age feature details to Cookie Store API MDN page mdn/mdn#775
• The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)

---

Preview | Diff

[annevk]

For other fields we have some validation. Do we want to throw if both expires and maxAge are passed?

[aamuley]

hmm i was planning to let that decision fall to the rfc and just prefer the maxAge if both are specified since that might be more expected behavior for devs, wdyt @DCtheTall?

[annevk]

Once we start targeting the layered-cookies I-D instead of the current RFC, I'm pretty sure we'll need to resolve the duplication locally anyway as we're not going to serialize what we have and feed it into the parser, but instead we'll create a cookie instance here and use that.

[aamuley]

Oh I didnt realize that, happy to check which is specified and throw an error in that case. Would you rather we construct a unified expiry time (between max-age and expires) in this algorithm right now, or leave that for when the RFC is being updated?

[annevk]

I think we should leave that until we update this specification to target the layered-cookies I-D.

@bakulf thoughts on all this?

[DCtheTall]

LGTM, just one suggestion

[aamuley]

fyi, updated the initial PR description now the wpts merged web-platform-tests/wpt@0f2fc46. also @annevk mind if I list WebKit as an interested implementer, or would you rather I follow up on the original Cookie Store API stds position request?

[annevk]

You can list WebKit as interested. We also need a WPT PR to rename the tests away from tentative.