Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maxByteLength option to Body consume utilities #1600

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Feb 1, 2023

This commit adds an option bag to Body/arrayBuffer, Body/blob, Body/formData, Body/json, and Body/text that allows configuration of a max byte length for the underlying consumed body. This allows a developer to limit how much data their application parses without having to resort to a costly user-land TransformStream that may break internal optimizations of the body consume helpers.

Closes #1592


  • At least two implementers are interested (and none opposed):
    • Deno
    • Cloudflare Workers
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
    • Deno: …
  • MDN issue is filed: …

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

This commit adds an option bag to `Body/arrayBuffer`, `Body/blob`,
`Body/formData`, `Body/json`, and `Body/text` that allows configuration
of a max byte length for the underlying consumed body. This allows a
developer to limit how much data their application parses without having
to resort to a costly user-land TransformStream that may break internal
optimizations of the body consume helpers.
@annevk annevk added addition/proposal New features or enhancements needs implementer interest Moving the issue forward requires implementers to express interest topic: api labels Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition/proposal New features or enhancements needs implementer interest Moving the issue forward requires implementers to express interest topic: api
Development

Successfully merging this pull request may close these issues.

Add size limiter to Body#formData method
2 participants