Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the media element pseudo-classes #10051

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Add the media element pseudo-classes #10051

merged 1 commit into from
Jan 16, 2024

Conversation

annevk
Copy link
Member

@annevk annevk commented Jan 11, 2024

These have been in Selectors for a while, but require host integration. The usage of public API in the definition feels justified given the current state of the media element section, though I tried to minimize it.

Test coverage can be found here:

(See WHATWG Working Mode: Changes for more details.)


/media.html ( diff )
/semantics-other.html ( diff )

These have been in Selectors for a while, but require host integration. The usage of public API in the definition feels justified given the current state of the media element section, though I tried to minimize it.

Test coverage can be found here:

* https://wpt.fyi/css/selectors/media/media-loading-state.html
* https://wpt.fyi/css/selectors/media/media-playback-state.html
* https://wpt.fyi/css/selectors/media/sound-state.html
* https://wpt.fyi/results/css/selectors/invalidation/media-pseudo-classes-in-has.html
* https://wpt.fyi/results/css/selectors/invalidation/media-loading-pseudo-classes-in-has.html
@annevk
Copy link
Member Author

annevk commented Jan 11, 2024

@whatwg/media care to review?

Copy link
Contributor

@hober hober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorially LGTM; not sure what the current implementation status of these is.

@annevk
Copy link
Member Author

annevk commented Jan 15, 2024

@padenot you/Gecko still happy with these?

@foolip Chromium?

Still seems good to determine implementer interest as I guess in theory a host-dependent pseudo-class being standardized in Selectors doesn't mean anything if there's no host that does anything with it.

@padenot
Copy link

padenot commented Jan 16, 2024

Mozilla position: this is a good initial set.

@annevk annevk merged commit 58ff4f3 into main Jan 16, 2024
2 checks passed
@annevk annevk deleted the resource-state-pseudos branch January 16, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants