Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax <select> parser #10557

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
+133 −329
Open

Relax <select> parser #10557

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1330ad5
Relax <select> parser
josepharhar Jul 15, 2024
b87d93d
make rules more permissive
josepharhar Sep 18, 2024
9c72f6c
dont allow hr in option
josepharhar Sep 20, 2024
e07cb01
re-add out of select cases
josepharhar Oct 2, 2024
5117d13
re-add reconstruct formatting elements
josepharhar Oct 3, 2024
33370b7
fix non-select case
josepharhar Oct 9, 2024
76e0d7f
fix variable names
josepharhar Oct 9, 2024
58b9ca9
re-add reconstruct active formatting elements
josepharhar Oct 10, 2024
b8ba8e6
remove pop optgroup
josepharhar Oct 10, 2024
c37560a
Always reconstruct formatting context
josepharhar Nov 21, 2024
e615f9b
fix hr generate implied end tags
josepharhar Nov 21, 2024
53fa2f4
in reverse tree order
josepharhar Nov 21, 2024
5c0627d
<select><select>
josepharhar Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129408,6 +129408,9 @@ document.body.appendChild(text);
<code>option</code> element in scope</span>, then this is a <span>parse error</span>.</p></li>
</ol>

<p>Otherwise, if the <span>current node</span> is an <code>option</code> element, then pop the
<span>current node</span> off the <span>stack of open elements</span>.</p>
josepharhar marked this conversation as resolved.
Show resolved Hide resolved

<p><span>Insert an HTML element</span> for the token.</p>
</dd>

Expand All @@ -129425,6 +129428,18 @@ document.body.appendChild(text);
error</span>.</p></li>
</ol>

<p>Otherwise:</p>

<ol>
<li><p>If the <span>current node</span> is an <code>option</code> element, and the node
immediately before it in the <span>stack of open elements</span> is an <code>optgroup</code>
element, then pop the <span>current node</span> from the <span>stack of open
elements</span>.</p></li>

josepharhar marked this conversation as resolved.
Show resolved Hide resolved
<li><p>If the <span>current node</span> is an <code>optgroup</code> element, then pop that node
from the <span>stack of open elements</span>.</p></li>
josepharhar marked this conversation as resolved.
Show resolved Hide resolved
</ol>
josepharhar marked this conversation as resolved.
Show resolved Hide resolved

<p><span>Insert an HTML element</span> for the token.</p>
</dd>

Expand Down