Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dialog light dismiss behavior #10737

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Add dialog light dismiss behavior #10737

wants to merge 17 commits into from
+326 −32

Commits on Nov 16, 2024

  1. Add closedby attribute to <dialog> 

    First commit is pulled from whatwg#10157
    @mfreed7
    mfreed7 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    4a93ad6 View commit details
    Browse the repository at this point in the history

  2. Small tweaks

    @mfreed7
    mfreed7 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    3630019 View commit details
    Browse the repository at this point in the history

  3. Add requestClose()

    @mfreed7
    mfreed7 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    32c2240 View commit details
    Browse the repository at this point in the history

  4. Fix tag nesting

    @mfreed7
    mfreed7 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    78f9789 View commit details
    Browse the repository at this point in the history

  5. Move note out of OL

    @mfreed7
    mfreed7 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    b99c5ac View commit details
    Browse the repository at this point in the history

  6. Address comments

    @mfreed7
    mfreed7 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    8698d0b View commit details
    Browse the repository at this point in the history

  7. Check for open attribute

    @mfreed7
    mfreed7 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    f50198e View commit details
    Browse the repository at this point in the history

  8. Adjust algorithm to match impl and tests

    @mfreed7
    mfreed7 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    fb01762 View commit details
    Browse the repository at this point in the history

  9. Address comments

    @mfreed7
    mfreed7 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    4f205bd View commit details
    Browse the repository at this point in the history

  10. Update attribute index

    @mfreed7
    mfreed7 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    38bdafe View commit details
    Browse the repository at this point in the history

  11. Adjustments from dbaron

    @mfreed7
    mfreed7 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    873e451 View commit details
    Browse the repository at this point in the history

  12. Fix up the return value

    @mfreed7
    mfreed7 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    e7fbbec View commit details
    Browse the repository at this point in the history

  13. Fix up closewatcher

    @mfreed7
    mfreed7 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    8b019a4 View commit details
    Browse the repository at this point in the history

  14. Fix up ol/li/p

    @mfreed7
    mfreed7 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    b57968e View commit details
    Browse the repository at this point in the history

  15. Some cleanup

    @mfreed7
    mfreed7 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    ea474af View commit details
    Browse the repository at this point in the history

  16. Fix "empty" xref

    @mfreed7
    mfreed7 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    db56191 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Address domenic@ comments

    @mfreed7
    mfreed7 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    82a4561 View commit details
    Browse the repository at this point in the history