Loosen DOMString? getter to accommodate ARIA-style string reflection #10974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you clarify which of the paths outlined in #10037 this follows? |
|
@domenic Apologies, please see this latest comment in the issue: #10037 (comment). |
annevk
reviewed
Feb 14, 2025
source
Outdated
| @@ -8183,36 +8183,39 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute | |||
| data-x="idl-DOMString">DOMString</span>?</code>:</p> | |||
|
|
|||
| <ul> | |||
| <li> | |||
| <p>The getter steps are:</p> | |||
| <li> | |||
There was a problem hiding this comment.
Could you please undo this throughout? We use single-space indentation.
annevk
reviewed
Feb 17, 2025
Comment on lines
+8202
to
+8203
| the <span>reflected IDL attribute</span> is defined to be <span>limited to only known | ||
| values</span>:</p> |
There was a problem hiding this comment.
I think we want "limited to only known values" to continue to be an assert. (But now as a substep of this.)
I think we also want the known state assert to remain. (But now as a substep of this.)
|
|
||
| <li><p>If <var>contentAttributeValue</var> corresponds to a state of | ||
| <var>attributeDefinition</var> with no associated keyword value, then return null.</p></li> | ||
| <li><p>If <var>contentAttributeValue</var> is null, then return null.</p></li> |
There was a problem hiding this comment.
This step is redundant with the next step so let's remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #10037.
The ARIA WG is currently working on improving IDL which includes converting ARIA attributes (where applicable/possible) to be truly enumerated.
As a subtask of this general work, this PR loosens HTML spec to allow
DOMString?reflection that is not limited to only known values. This is desirable for non-enumerated ARIA content attributes (e.g.,aria-label,role) where the most appropriate IDL attribute type isDOMString?and the absence of the attribute's value is meaningful. This change will also ensure HTML-conformant reflection for future ARIA attributes that require string reflection.CC @annevk
(See WHATWG Working Mode: Changes for more details.)
/acknowledgements.html ( diff )
/common-dom-interfaces.html ( diff )