style: use title case for attr-translate-yes-state and attr-translate… #11027

HarshitGourlariya · 2025-02-14T12:38:39Z

…-no-state
Use title case for attr-translate-* attributes

This PR corrects the capitalization of several attr-translate-* attributes to use title case. This ensures consistency in how translation-related attributes are handled and improves the overall readability of the HTML specification.

Specifically, the following attributes were updated:

attr-translate-yes-state
attr-translate-no-state

At least two implementers are interested (and none opposed):
- …
- …
Tests are written and can be reviewed and commented upon at:
- …
Implementation bugs are filed:
- Chromium: …
- Gecko: …
- WebKit: …
- Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): …
- Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): …
Corresponding HTML AAM & ARIA in HTML issues & PRs:
MDN issue is filed: …
The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)

/dnd.html ( diff )
/dom.html ( diff )
/embedded-content.html ( diff )
/form-control-infrastructure.html ( diff )
/forms.html ( diff )
/images.html ( diff )
/infrastructure.html ( diff )
/interaction.html ( diff )
/parsing.html ( diff )
/popover.html ( diff )
/scripting.html ( diff )
/semantics-other.html ( diff )
/semantics.html ( diff )
/tables.html ( diff )
/urls-and-fetching.html ( diff )

…-no-state

annevk

You need to remove the grep_results.txt file. I also have a number of nits. Note that "Title Case" means that each word has to start with a capital.

annevk · 2025-02-14T12:57:59Z

source

@@ -1857,7 +1857,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute
   </li>

   <li><p>If <var>removedNode</var>'s <code data-x="attr-popover">popover</code> attribute is not in
-   the <span data-x="attr-popover-none-state">no popover state</span>, then run the <span>hide
+   the <span data-x="attr-popover-none-state">No popover state</span>, then run the <span>hide


This needs to be "No Popover State", right?

ok Working on it .

This is still not addressed.

"I've resolved the issue. Please review."

annevk · 2025-02-14T12:58:25Z

source

@@ -13770,22 +13770,22 @@ Transport Protocol">HTTP&lt;/abbr> today.&lt;/p></code></pre> <!-- DO NOT REWRAP
   <tbody>
    <tr>
     <td><dfn attr-value for="html-global/dir"><code data-x="attr-dir-ltr">ltr</code></dfn>
-     <td><dfn data-x="attr-dir-ltr-state">ltr</dfn>
+     <td><dfn data-x="attr-dir-ltr-state">Ltr</dfn>


This should be LTR and Rtl should be RTL.

annevk · 2025-02-14T12:58:53Z

source

     <td>The header cell applies to some of the subsequent cells in the same column(s).
    <tr>
     <td><dfn attr-value for="th/scope"><code data-x="attr-th-scope-rowgroup">rowgroup</code></dfn>
-     <td><dfn data-x="attr-th-scope-rowgroup-state">row group</dfn>
+     <td><dfn data-x="attr-th-scope-rowgroup-state">Row group</dfn>


Row Group, also Column Group below.

annevk · 2025-02-14T12:59:22Z

source

   have to take care when writing their style sheets to make sure that the attribute is still styled
   as expected. In addition, legacy user agents which don't support the <span
-   data-x="attr-hidden-until-found-state">hidden until found</span> state will have 'display: none'
+   data-x="attr-hidden-until-found-state">Hidden until found</span> state will have 'display: none'


This would be Hidden Until Found.

annevk · 2025-02-14T12:59:47Z

source

@@ -30431,7 +30431,7 @@ was an English &lt;a href="/wiki/Music_hall">music hall&lt;/a> singer, ...</code
    <div class="example">

     <p>This example is the same as the previous example, but the image is <span
-     data-x="attr-loading-lazy-state">lazy-loaded</span>. In this case, the <code
+     data-x="attr-loading-lazy-state">Lazy-loaded</span>. In this case, the <code


Lazy-Loaded or maybe Lazy Loaded.

annevk · 2025-02-14T13:00:22Z

source

@@ -82941,20 +82942,20 @@ body { display:none }
  data-x="">window.find()</code> API.</p>

  <h4>Interaction with <code>details</code> and <code
-  data-x="attr-hidden-until-found-state">hidden=until-found</code></h4>
+  data-x="attr-hidden-until-found-state">Hidden=until-found</code></h4>


Here the casing should probably not change.

HarshitGourlariya · 2025-02-14T13:45:04Z

"I've addressed the issue identified in the review. The calculation error has been corrected. Please take another look."

annevk · 2025-02-14T14:29:01Z

It still says that this PR changes 2 files so I think you need to take another look.

HarshitGourlariya · 2025-02-14T14:54:19Z

I've removed grep_results.txt from the PR as it was mistakenly included.
The commit now accurately reflects the intended changes.

annevk · 2025-02-14T16:21:05Z

source

@@ -1857,7 +1857,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute
   </li>

   <li><p>If <var>removedNode</var>'s <code data-x="attr-popover">popover</code> attribute is not in
-   the <span data-x="attr-popover-none-state">no popover state</span>, then run the <span>hide
+   the <span data-x="attr-popover-none-state">No popover state</span>, then run the <span>hide


This is still not addressed.

annevk · 2025-02-14T16:21:41Z

source

@@ -75065,7 +75065,7 @@ Demos:
    <p>The <code data-x="selector-popover-open">:popover-open</code> <span>pseudo-class</span> is
    defined to match any <span data-x="html elements">HTML element</span> whose <code
    data-x="attr-popover">popover</code> attribute is not in the <span
-    data-x="attr-popover-none-state">no popover state</span> and whose <span>popover visibility
+    data-x="attr-popover-none-state">No popover state</span> and whose <span>popover visibility


annevk · 2025-02-14T16:21:51Z

source

     <td rowspan=2>Will not be rendered.
    <tr>
     <td>(the empty string)
    <tr>
     <td><dfn attr-value for="html-global/hidden"><code data-x="attr-hidden-until-found">until-found</code></dfn>
-     <td><dfn data-x="attr-hidden-until-found-state">hidden until found</dfn>
+     <td><dfn data-x="attr-hidden-until-found-state">Hidden until found</dfn>


annevk · 2025-02-14T16:22:03Z

source

     <td>Will not be rendered, but content inside will be accessible to <span>find-in-page</span>
     and <span data-x="navigate-fragid">fragment navigation</span>.
  </table>

  <p>The attribute's <i data-x="missing value default">missing value default</i> is the <dfn
-  data-x="attr-hidden-not-hidden-state">not hidden</dfn> state, and its <i data-x="invalid value
-  default">invalid value default</i> is the <span data-x="attr-hidden-hidden-state">hidden</span>
+  data-x="attr-hidden-not-hidden-state">Not hidden</dfn> state, and its <i data-x="invalid value


annevk · 2025-02-14T16:22:18Z

source

  indirectly through the style layer. For example, a web browser could implement these requirements
  <a href="#hiddenCSS">using the rules suggested in the Rendering section</a>.</p>

  <p>When an element has the <code data-x="attr-hidden">hidden</code> attribute in the <span
-  data-x="attr-hidden-until-found-state">hidden until found</span> state, it indicates that the
-  element is hidden like the <span data-x="attr-hidden-hidden-state">hidden</span> state but the
+  data-x="attr-hidden-until-found-state">Hidden until found</span> state, it indicates that the


annevk · 2025-02-14T16:22:50Z

source

@@ -79018,35 +79018,35 @@ END:VCARD</pre>

  <p>Web browsers will use 'content-visibility: hidden' instead of 'display: none' when the <code
  data-x="attr-hidden">hidden</code> attribute is in the <span
-  data-x="attr-hidden-until-found-state">hidden until found</span> state, as specified in the <a
+  data-x="attr-hidden-until-found-state">Hidden until found</span> state, as specified in the <a


Ditto.

I stopped here. Please make sure the entire PR uses title case for enumeration states. Thanks!

HarshitGourlariya · 2025-02-14T16:29:28Z

ok

HarshitGourlariya · 2025-02-15T05:28:35Z

"I've resolved the issue. Please review."

annevk

Nice, I found one more to address (multiple times, to be clear), but looks like a solid improvement otherwise.

annevk · 2025-02-17T08:10:37Z

source

     <td>The element is not editable.
    <tr>
     <td><dfn attr-value for="html-global/contenteditable"><code
     data-x="attr-contenteditable-plaintextonly">plaintext-only</code></dfn>
-     <td><dfn data-x="attr-contenteditable-plaintextonly-state">plaintext-only</dfn>
+     <td><dfn data-x="attr-contenteditable-plaintextonly-state">Plaintext-only</dfn>


Has to be Plaintext-Only throughout.

annevk · 2025-02-17T08:12:59Z

@HarshitGourlariya apart from that, could you please read and sign https://participate.whatwg.org/agreement? Thank you!

HarshitGourlariya · 2025-02-17T16:18:08Z

Thanks for reviewing my commits. I have made the changes related to the Plaintext-Only issue.

annevk · 2025-02-17T16:52:55Z

It seems you only fixed one instance?

HarshitGourlariya · 2025-02-18T04:49:18Z

You said you found "Plaintext-Only" throughout the entire code, which was not properly addressed. So, I made changes to that in my latest commit.

annevk · 2025-02-18T08:53:43Z

I said it has to be "Plaintext-Only" throughout. You changed one instance of "Plaintext-only" to "Plaintext-Only", but my comment signified (through the use of "throughout") that there are multiple instances of "Plaintext-only" that need to be replaced.

HarshitGourlariya · 2025-02-19T07:10:01Z

"I found only two plaintext-related issues and have updated them. Please review."

annevk · 2025-02-19T07:15:21Z

That last commit went wrong it seems. I recommend double checking before pushing next time.

HarshitGourlariya · 2025-02-19T08:11:00Z

I have fixed the issue. Please review.

annevk · 2025-02-19T08:52:41Z

@HarshitGourlariya

style: use title case for attr-translate-yes-state and attr-translate… #11027 (comment) is still unresolved it seems. You haven't signed the agreement.
From the Build check it also appears you introduced trailing whitespace. You'll have to remove that.

style: use title case for attr-translate-yes-state and attr-translate…

b30d644

…-no-state

HarshitGourlariya mentioned this pull request Feb 14, 2025

[Editorial] "state" keywords have inconsistent casing #10802

Open

annevk reviewed Feb 14, 2025

View reviewed changes

Fixes whatwg#11027: Corrected the error

13f48de

Remove grep_results.txt

d3609ec

annevk reviewed Feb 14, 2025

View reviewed changes

editorial: Use title case for attribute states

9e4e7e0

HarshitGourlariya requested a review from annevk February 15, 2025 15:32

annevk reviewed Feb 17, 2025

View reviewed changes

Errors Fixed

8e1c85b

Changes made

e5b5d49

Errors Fixed

2ac8522

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

style: use title case for attr-translate-yes-state and attr-translate… #11027

style: use title case for attr-translate-yes-state and attr-translate… #11027

HarshitGourlariya commented Feb 14, 2025 •

edited by pr-preview bot

Loading

annevk left a comment

annevk Feb 14, 2025

HarshitGourlariya Feb 14, 2025

annevk Feb 14, 2025

HarshitGourlariya Feb 15, 2025

annevk Feb 14, 2025

annevk Feb 14, 2025

annevk Feb 14, 2025

annevk Feb 14, 2025

annevk Feb 14, 2025

HarshitGourlariya commented Feb 14, 2025

annevk commented Feb 14, 2025

HarshitGourlariya commented Feb 14, 2025

annevk Feb 14, 2025

annevk Feb 14, 2025

annevk Feb 14, 2025

annevk Feb 14, 2025

annevk Feb 14, 2025

annevk Feb 14, 2025

HarshitGourlariya commented Feb 14, 2025

HarshitGourlariya commented Feb 15, 2025

annevk left a comment

annevk Feb 17, 2025

annevk commented Feb 17, 2025

HarshitGourlariya commented Feb 17, 2025

annevk commented Feb 17, 2025

HarshitGourlariya commented Feb 18, 2025

annevk commented Feb 18, 2025

HarshitGourlariya commented Feb 19, 2025

annevk commented Feb 19, 2025

HarshitGourlariya commented Feb 19, 2025

annevk commented Feb 19, 2025

style: use title case for attr-translate-yes-state and attr-translate… #11027

Are you sure you want to change the base?

style: use title case for attr-translate-yes-state and attr-translate… #11027

Conversation

HarshitGourlariya commented Feb 14, 2025 • edited by pr-preview bot Loading

annevk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HarshitGourlariya commented Feb 14, 2025

annevk commented Feb 14, 2025

HarshitGourlariya commented Feb 14, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HarshitGourlariya commented Feb 14, 2025

HarshitGourlariya commented Feb 15, 2025

annevk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annevk commented Feb 17, 2025

HarshitGourlariya commented Feb 17, 2025

annevk commented Feb 17, 2025

HarshitGourlariya commented Feb 18, 2025

annevk commented Feb 18, 2025

HarshitGourlariya commented Feb 19, 2025

annevk commented Feb 19, 2025

HarshitGourlariya commented Feb 19, 2025

annevk commented Feb 19, 2025

HarshitGourlariya commented Feb 14, 2025 •

edited by pr-preview bot

Loading