-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Origin-Agent-Cluster HTTP header default #7617
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! You'll need to make your membership of the googlers GitHub organization public.
I suggest we merge this after it has successfully shipped and stuck for a month or so.
I think we need more updates, mostly to the non-normative introductory text. E.g. https://whatpr.org/html/7617/origin.html#origin-keyed-agent-clusters says
but it should probably say something like "By default, a Document is in an origin-keyed agent cluster. The Origin-Agent-Cluster header can be used to opt out of this behavior and become site-keyed." Similarly, with the paragraph starting "The consequences of using this header are that the resulting Document's agent cluster key is its origin..." |
That's a good point. We also want to move/adjust this
Minor adjustments in "Integration with the JavaScript agent formalism" might be welcome as well, although I think the existing text could work. |
Heya, it's been a while. This change was launched on Chrome somewhere late '2023 and has been enabled ever since. I've rebased this spec PR to the current head. An easy way to check is e.g. to go to https://www.example.org/ (which does not set any headers) and execute I have not heard any user complaints in the recent months. Early user complaints focused on a particular, no longer sold but still maintained enterprise product. The vendor had provided a timely update but this required manual actions to update for each customer that was still using it, which apparently took a while. (Said vendor's newer products didn't have issues.) I think now would be a good time to land this change. |
Since this is a normative change, it would be good if it followed https://github.com/whatwg/html/blob/main/PULL_REQUEST_TEMPLATE.md. Based on a quick scan we need browser bugs and an MDN issue. |
I am working with Daniel on finishing this up. I've updated the OP with the modern pull request template. The biggest blocker is updating all the WPTs for the new default. Daniel is working on doing so. Once that is done, I'll link to the update, and take care of filing bugs and MDN issues. |
All boxes in the OP are filled out, although Daniel's work on updating the tests is currently in "draft" status. (But they are all passing.) I'll merge this once those are slightly more far along. |
This changes the default behavior for the Origin-Agent-Cluster header from false to true. That is, an absent header was equivalent to false (
?0
) and is now equivalent to true (?1
).(See WHATWG Working Mode: Changes for more details.)
/browsers.html ( diff )
/document-lifecycle.html ( diff )
/webappapis.html ( diff )