Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Web IDL integer types and 128-bit unsigned #648

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented Nov 15, 2024

Fixes #647.


Preview | Diff

@annevk annevk requested a review from domenic November 15, 2024 15:01
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

infra.bs Outdated Show resolved Hide resolved
infra.bs Outdated

<hr>

<p>An <dfn export>8-bit signed integer</dfn> is an integer in the range -128 to 127 (-2<sup>7</sup>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In HTML at least, we use &minus; for negative signs too. I've always been a bit conflicted about that as I think it's typographically more correct, but it makes copying and pasting into code worse... I'm OK to leave it up to you but maybe we should raise a meta issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to stick with &minus;. I should have double checked this in HTML.

@annevk annevk merged commit 2410293 into main Nov 18, 2024
2 checks passed
@annevk annevk deleted the integer-types branch November 18, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Define ranged integer types
2 participants