Editorial: adopt Infra number definitions (and redo IPv6 pieces) #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
commented
Nov 19, 2024
Comment on lines
+1448
to
1458
| <li><p>Let <var>compress</var> be null. | ||
|
|
||
| <li> | ||
| <p>Let <var>compress</var> be an index to the first <a>IPv6 piece</a> in the first longest | ||
| sequences of <var>address</var>'s <a>IPv6 pieces</a> that are 0. | ||
| <p>If multiple <var>address</var>'s <a for="IPv6 address">pieces</a> are 0 sequentially, then set | ||
| <var>compress</var> to the index of the first item of the first of the longest sequences of | ||
| <var>address</var>'s <a for="IPv6 address">pieces</a> that are 0. | ||
|
|
||
| <p class=example id=example-e2b3492e>In <code>0:f:0:0:f:f:0:0</code> it would point to | ||
| the second 0. | ||
|
|
||
| <li><p>If there is no sequence of <var>address</var>'s <a>IPv6 pieces</a> that are 0 that is | ||
| longer than 1, then set <var>compress</var> to null. | ||
|
|
||
| <li><p>Let <var>ignore0</var> be false. |
There was a problem hiding this comment.
This is probably the biggest change here.
There was a problem hiding this comment.
I think this changed from excluding 1-length sequences to including them.
FYI here is whatwg-url's implementation. It might be worth writing the whole thing out as it's pretty complex. https://github.com/jsdom/whatwg-url/blob/0fb65e3c3671c2e790ff38aed9332fc7fb2cd12b/lib/url-state-machine.js#L387
There was a problem hiding this comment.
I was hoping that multiple and sequentially would do that work here. I could rewrite this though. #321 also requested that. Hopefully next week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff