Skip to content

fix(config): walk up two levels for monorepo box.json in $readFrameworkVersion #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bpamiri merged 1 commit into from
Apr 24, 2026
Merged

fix(config): walk up two levels for monorepo box.json in $readFrameworkVersion #2293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vendor/wheels/Global.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2788,7 +2788,7 @@ return local.$wheels;
// homepage shows the upcoming version rather than a blank placeholder.
local.rootPath = Len(arguments.rootBoxJsonPath)
? arguments.rootBoxJsonPath
: GetDirectoryFromPath(GetCurrentTemplatePath()) & "../box.json";
: GetDirectoryFromPath(GetCurrentTemplatePath()) & "../../box.json";
try {
if (FileExists(local.rootPath)) {
local.rootBox = DeserializeJSON(FileRead(local.rootPath));
Expand Down
35 changes: 35 additions & 0 deletions vendor/wheels/tests/specs/events/frameworkVersionSpec.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,41 @@ component extends="wheels.WheelsTest" {
}
});

it("application.wheels.version resolves to <rootversion>-dev at boot in a monorepo dev checkout (regression for ##2291)", () => {
// Regression for ##2291. Asserts the *runtime boot* result — not a direct
// call — because $readFrameworkVersion is bound into the spec's scope by
// WheelsTest.cfc, which shifts GetCurrentTemplatePath() to this file and
// bypasses the code path we want to cover. application.wheels.version is
// populated by onapplicationstart.cfc calling $readFrameworkVersion() with
// no arguments, so whatever it resolved to is the answer we need to check.
//
// With the bug (one-level "../box.json"): default rootBoxJsonPath points at
// vendor/box.json, which does not exist, so the helper falls through to
// "0.0.0-dev" even in a monorepo checkout.
// With the fix (two-level "../../box.json"): default rootBoxJsonPath points
// at <repo-root>/box.json and yields "<rootversion>-dev".
var wheelsDir = ExpandPath("/wheels/");
var fwBoxPath = wheelsDir & "box.json";
var rootBoxPath = wheelsDir & "../../box.json";
if (!FileExists(fwBoxPath) || !FileExists(rootBoxPath)) {
return;
}
var fwBox = DeserializeJSON(FileRead(fwBoxPath));
var rootBox = DeserializeJSON(FileRead(rootBoxPath));
if (!IsStruct(fwBox) || (fwBox.version ?: "") != "@build.version@") {
return;
}
var isWheelsRepo = IsStruct(rootBox)
&& (
((rootBox.slug ?: "") == "wheels")
|| ((rootBox.name ?: "") == "Wheels.fw")
);
if (!isWheelsRepo || (rootBox.version ?: "") == "" || rootBox.version == "@build.version@") {
return;
}
expect(application.wheels.version).toBe(rootBox.version & "-dev");
});

it("$readFrameworkVersion throws Wheels.VersionReadFailed when the file is missing", () => {
var missing = getTempDirectory() & "wheels-version-missing-#CreateUUID()#.json";
var threw = false;
Expand Down