fix(cli): escape literal # in resolveFrameworkSourceOrFail help text - #2298
Merged
Conversation
Two help-text lines added in #2294 contained a single literal `#` (shell-comment marker shown in the manual-recovery instructions). CFML treats `#` as the start of a `#expr#` interpolation, so Lucee parsed `# Pick the wheels-core-<version>.zip…` as an unterminated interpolation and failed Module.cfc compilation: Invalid Syntax Closing [#] not found, at [3540:22] This broke the post-merge Wheels Snapshots run on develop — the "Smoke Test Installed Distribution" job in the same release workflow the original PR added to catch exactly this class of regression. Doubled `#` to `##` on both lines (CFML's literal-hash escape). The other `#` references in the surrounding block (`#appName#`, `#candidate#`, `#projectCandidate#`) are proper interpolations and remain unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two help-text lines added in #2294 contained a single literal
#(a shell-comment marker shown to users in the manual-recovery instructions). CFML treats#as the start of a#expr#interpolation, so Lucee parsed the strings as unterminated interpolations andModule.cfcfailed to compile:This broke the post-merge
Wheels Snapshotsrun ondevelop(run 24922776182) — specifically the Smoke Test Installed Distribution job that #2294 added to catch exactly this class of distribution-time regression. The smoke test did its job; this PR addresses what it found.Fix
Doubled
#to##on the two affected lines — CFML's literal-hash escape.The other
#references in the surrounding block (#appName#,#candidate#,#projectCandidate#) are proper interpolations with matched pairs and remain unchanged.Test plan
Wheels Snapshotsrun ondeveloppasses the Smoke Test Installed Distribution jobwheels newfrom a context where framework source is missing now prints the recovery instructions instead of throwing a CFML compile error🤖 Generated with Claude Code