Skip to content

fix(web): make lockup logo color-scheme aware so it stays visible in dark mode #3284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bpamiri merged 1 commit into from
Jul 6, 2026
Merged

fix(web): make lockup logo color-scheme aware so it stays visible in dark mode #3284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/3264-dark-mode-logo.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fixed the wheels.dev header and footer logo being invisible in dark mode — the `lockup` logo variant now swaps to the white lockup under `prefers-color-scheme: dark` via a pure-CSS toggle ([#3264](https://github.com/wheels-dev/wheels/issues/3264))
47 changes: 40 additions & 7 deletions web/packages/ui/src/components/Logo.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,12 @@ const lockupHeights = {
md: 28,
lg: 40,
};

const isLockup = variant === 'lockup' || variant === 'lockup-on-dark';
const src =
variant === 'mark' ? markPng : variant === 'lockup-on-dark' ? lockupWhitePng : lockupPng;
---

{
variant === 'mark' && (
<img
src={src.src}
src={markPng.src}
width={markSizes[size].w}
height={markSizes[size].h}
alt="Wheels"
Expand All @@ -43,9 +39,32 @@ const src =
}

{
isLockup && (
variant === 'lockup' && (
<>
<img
src={lockupPng.src}
height={lockupHeights[size]}
alt="wheels.dev"
class:list={['wd-logo', 'wd-logo--lockup', 'wd-logo--lockup-light', className]}
loading="eager"
decoding="async"
/>
<img
src={lockupWhitePng.src}
height={lockupHeights[size]}
alt="wheels.dev"
class:list={['wd-logo', 'wd-logo--lockup', 'wd-logo--lockup-dark', className]}
loading="eager"
decoding="async"
/>
</>
)
}

{
variant === 'lockup-on-dark' && (
<img
src={src.src}
src={lockupWhitePng.src}
height={lockupHeights[size]}
alt="wheels.dev"
class:list={['wd-logo', 'wd-logo--lockup', className]}
Expand All @@ -63,4 +82,18 @@ const src =
.wd-logo--lockup {
width: auto;
}
/* Auto color-scheme lockup: dark-ink in light mode, white in dark mode.
The site's dark mode is CSS-only (prefers-color-scheme in tokens.css),
so the swap must be pure CSS too — see #3264. */
.wd-logo--lockup-dark {
display: none;
}
@media (prefers-color-scheme: dark) {
.wd-logo--lockup-light {
display: none;
}
.wd-logo--lockup-dark {
display: inline-block;
}
}
</style>
Loading