fix: replace HTMLEditFormat with EncodeForHTML in packagelist - #3392
Merged
Conversation
Adobe ColdFusion 2025 does not provide HTMLEditFormat, so the Packages admin page 500s. Switch those call sites to EncodeForHTML, the encoder already used by other /wheels admin views. See #3378. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Peter Amiri <peter@alurium.com>
bpamiri
marked this pull request as ready for review
August 21, 2026 12:09
bpamiri
marked this pull request as draft
August 21, 2026 12:11
bpamiri
marked this pull request as ready for review
August 21, 2026 12:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adobe ColdFusion 2025 does not provide
HTMLEditFormat, so GET/wheels/packages500s withVariable HTMLEDITFORMAT is undefined. This is one of the two bugs reported on #3378 (the other is wheels-basecoatboolean switchand is out of scope here).vendor/wheels/public/views/packagelist.cfmnow usesEncodeForHTMLat every formerHTMLEditFormatsite — the same encoder already used by other/wheelsadmin views (helpers.cfm,routetesterprocess.cfm). Escaped output is unchanged. No other public views calledHTMLEditFormat.Related Issue
#3378 (packages-admin half only; does not address the Basecoat
switchcompile error)Type of Change
Feature Completeness Checklist
Signed-off-by:packagelist.cfmno longer callsHTMLEditFormatand encodes withEncodeForHTMLchangelog.d/3378-packagelist-encodeforhtml.fixed.mdwheels.tests.specs.packageson Lucee 7 + SQLite: 136 pass / 0 fail / 0 errorTest Plan
vendor/wheels/public/views/packagelist.cfmhas zeroHTMLEditFormatand usesEncodeForHTMLdirectory=wheels.tests.specs.packageson local Lucee 7 + SQLitePackageListHtmlEditFormatSpecfails against the old view (2 fail) and passes after this change (136 pass)Screenshots / Output
N/A — encoder swap; same escaped markup.
TDD red/green (Lucee 7 + SQLite,
directory=wheels.tests.specs.packages):HTMLEditFormatrestore): 134 pass, 2 fail (does not call HTMLEditFormat,encodes registry output with EncodeForHTML)