Skip to content

fix: replace HTMLEditFormat with EncodeForHTML in packagelist - #3392

Merged
bpamiri merged 1 commit into
developfrom
cursor/issue-3378-htmleditformat-a977
Aug 21, 2026
Merged

fix: replace HTMLEditFormat with EncodeForHTML in packagelist#3392
bpamiri merged 1 commit into
developfrom
cursor/issue-3378-htmleditformat-a977

Conversation

@bpamiri

@bpamiri bpamiri commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adobe ColdFusion 2025 does not provide HTMLEditFormat, so GET /wheels/packages 500s with Variable HTMLEDITFORMAT is undefined. This is one of the two bugs reported on #3378 (the other is wheels-basecoat boolean switch and is out of scope here).

vendor/wheels/public/views/packagelist.cfm now uses EncodeForHTML at every former HTMLEditFormat site — the same encoder already used by other /wheels admin views (helpers.cfm, routetesterprocess.cfm). Escaped output is unchanged. No other public views called HTMLEditFormat.

Related Issue

#3378 (packages-admin half only; does not address the Basecoat switch compile error)

Type of Change

  • Bug fix
  • New feature
  • Enhancement to existing feature
  • Documentation update
  • Refactoring

Feature Completeness Checklist

  • DCO sign-off -- Every commit carries Signed-off-by:
  • Tests -- Structural spec asserts packagelist.cfm no longer calls HTMLEditFormat and encodes with EncodeForHTML
  • Framework Docs -- N/A (admin-page encoder swap)
  • AI Reference Docs -- N/A
  • CLAUDE.md -- N/A
  • Changelog fragment -- changelog.d/3378-packagelist-encodeforhtml.fixed.md
  • Test runner passes -- wheels.tests.specs.packages on Lucee 7 + SQLite: 136 pass / 0 fail / 0 error

Test Plan

  • Source scan: vendor/wheels/public/views/packagelist.cfm has zero HTMLEditFormat and uses EncodeForHTML
  • directory=wheels.tests.specs.packages on local Lucee 7 + SQLite
  • Spec PackageListHtmlEditFormatSpec fails against the old view (2 fail) and passes after this change (136 pass)
  • Existing packagelist specs in the packages directory still pass

Screenshots / Output

N/A — encoder swap; same escaped markup.

TDD red/green (Lucee 7 + SQLite, directory=wheels.tests.specs.packages):

  • RED (temporary HTMLEditFormat restore): 134 pass, 2 fail (does not call HTMLEditFormat, encodes registry output with EncodeForHTML)
  • GREEN (this change): 136 pass, 0 fail, 0 error, 15 bundles
Open in Web Open in Cursor 

Adobe ColdFusion 2025 does not provide HTMLEditFormat, so the
Packages admin page 500s. Switch those call sites to EncodeForHTML,
the encoder already used by other /wheels admin views.

See #3378.

Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Peter Amiri <peter@alurium.com>
@bpamiri
bpamiri marked this pull request as ready for review August 21, 2026 12:09
@bpamiri
bpamiri marked this pull request as draft August 21, 2026 12:11
@bpamiri
bpamiri marked this pull request as ready for review August 21, 2026 12:11
@bpamiri
bpamiri merged commit 935c4ca into develop Aug 21, 2026
13 checks passed
@bpamiri
bpamiri deleted the cursor/issue-3378-htmleditformat-a977 branch August 21, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants