fix(model): fail closed when a validation condition cannot be evaluated - #3398
Merged
Merged
Conversation
…o evaluate Prove-red for M1: unevaluable condition/unless must throw Wheels.InvalidValidationCondition even when showErrorInformation is false. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Peter Amiri <peter@alurium.com>
Always throw Wheels.InvalidValidationCondition when condition/unless cannot be evaluated, including when showErrorInformation is false. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Peter Amiri <peter@alurium.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$evaluateConditionwas fail-open whenshowErrorInformationis false: an unevaluablecondition/unlessexpression was logged and the helper returnedfalse, which$validatetreats as “skip this validation.” A broken expression therefore skipped the guard in production.This PR always throws
Wheels.InvalidValidationCondition(same type and message shape as the existing development path) regardless ofshowErrorInformation.Type of Change
Feature Completeness Checklist
Signed-off-by:vendor/wheels/tests/specs/model/validationsSpec.cfcassert throw on unevaluableconditionandunlesswhenshowErrorInformation=falsechangelog.d/evaluate-condition-fail-closed.fixed.mdTest Plan
Driver (directory scope — a single-file
directory=discovers 0 bundles):7220553c2):967 passed, 2 failed. Both new specs: “The incoming function did not throw an expected exception. Type=[Wheels.InvalidValidationCondition]”.8c1af9c5f):969 passed.Hardener M1
$evaluateConditionfail-closed when showErrorInformation=falsewheels test --core --ci --filter=wheels.tests.specs.model— red 967/2, green 969HEAD:
8c1af9c5f5331d3c1907f5ffd3a6e20698c64c69Does not close unrelated issues. Does not start M2–M10.