fix: repair Adobe compat-matrix failures (database hardener spec + channel DDL) - #3436
Merged
Conversation
Three Adobe-only parser traps in the S6 optionsIncludeDefault describe: - a variable named `abstract` (reserved word on Adobe CF) — rename to abstractMigrator - `default` passed as a named argument to optionsIncludeDefault — use positional args - unquoted `default:` struct-literal keys — quote them Verified on Adobe 2023 + MySQL: database specs 101/0/0 (previously the whole leg failed at compile time with MissingNameException). Signed-off-by: Peter Amiri <peter@alurium.com>
The id column was varchar(36) (UUID-sized) but channel event ids can be arbitrarily long (spec ids like "test.hard.s1.<36 chars>" are 42+ chars), which made MySQL legs fail with "Data too long for column 'id'". Matches the channel/event columns' 255 width. Verified on Adobe 2023 + MySQL: channel specs 43/0/0. Signed-off-by: Peter Amiri <peter@alurium.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two pre-existing issues discovered while verifying the complexity burn-down (#3435) against the local compat matrix — both reproduced on
developand fixed here.1. Adobe compile failure in
DatabaseAdapterHardenerSpec.cfcThe S6
optionsIncludeDefaultdescribe crashed the entire Adobe leg at compile time (MissingNameException: Invalid construct: Either argument or name is missing) because of three Adobe-only parser traps:abstract(reserved word on Adobe CF)defaultpassed as a named argument (optionsIncludeDefault(type = "text", default = "..."))default:struct-literal keysFixed with positional args, quoted keys, and a renamed variable.
Verified: Adobe 2023 + MySQL,
specs.databasedirectory → 101 passed / 0 failed / 0 errors (previously: whole leg HTTP 500 at compile).2. Channel events table id too short for MySQL
wheels_events.idwasvarchar(36)(UUID-sized) while channel event ids can be arbitrarily long (42+ chars in the specs), so MySQL legs failed withData too long for column 'id'. Widened tovarchar(255)to match thechannel/eventcolumns.Verified: Adobe 2023 + MySQL,
specs.channeldirectory → 43 passed / 0 failed / 0 errors.Both fixes are test/DDL-only; no framework behavior change. The weekly compat-matrix should go green on the Adobe+MySQL legs once this lands.