perf(model): serve integration plan from the request scope - #3461
Merged
Conversation
The cached component-integration plan (#3236) was re-read from the application scope on every model/controller/mapper materialization — roughly six synchronized application-scope lookups per instance. The plan is stable within a request (the only invalidation is the rebuild-on-poison validation, which replaces both copies), so after its first use it is now served from a request-scope struct. Measured on the #3213 benchmark rig (Lucee 7, 2,000 model().new()): plan lookup 123ms -> 2ms, ~12-15% off total instantiation time. IntegrationPlanSpec now also pins the request-cache behavior (second call returns the same plan array) and the rebuild test clears the request cache so it still exercises the poisoned application-scope path. Signed-off-by: Peter Amiri <peter@alurium.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3213.
The cached component-integration plan (#3236) was re-read from the application scope on every model/controller/mapper materialization — roughly six synchronized application-scope lookups per instance. The plan is stable within a request (the only invalidation is the #3457 rebuild-on-poison validation, which replaces both copies), so after its first use per request it is now served from a request-scope struct.
Measured on the #3213 benchmark rig (Lucee 7, 2,000
model().new(), instrumented):Full breakdown of the remaining per-object cost is in the #3213 thread; the copy loop (~45%) and instance setup (~40%) are the next targets.
IntegrationPlanSpecnow also pins the request-cache behavior (second call returns the same plan array without touching the application scope) and the rebuild test clears the request cache so it still exercises the poisoned application-scope path.Verification