Http preprocessor improvement #364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lua has [[ ]] for raw string embedding This allow us to not track string quotes and output bigger chunk. The downside is that we are more likely to hit the buffer size limit of 2k, and miss a lot of preallocated buffer use. So we need to track the length of the line and break. This change also preserve blank line in raw text.
Avoid confusion with real lua file, and allow editor highlighting based on extension Note that preprocessed file end up with extension `.luaspp`
the0ne
reviewed
Jul 22, 2020
|
I agree with you about file location and separation. However, Webserver script pages are not lua scripts, they are html files with some part containing lua fragment of script. It is not uncommon to have lua statement split and interleaved with 'raw text'. Compare <html>
<body>
<table>
<?lua for i=1,10 do ?>
<tr><td> <?lua print(i) ?></td></tr>
<?lua end ?>
</table>
</body>
</html>to <html>
<body>
<table>
<?lua for i=1,10 do ?>
<tr><td> <?lua print(i) ?></td></tr>
<?lua end ?>
</table>
</body>
</html>If both files have, the same extension, is it way harder to instruct your editor how to colorise the file. Finally, there is no sense in doing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lua has
[[ ]]for raw string embeddingThis allow us to not track string quotes and output bigger chunk.
The downside is that we are more likely to hit the buffer size limit of 2k, and miss a lot of preallocated buffer use. So we need to track the length of the line and break.
This change also preserve blank line in raw text.
.luaspfor lua server pagesAvoid confusion with real lua file, and allow editor highlighting based on extension
Note that preprocessed file end up with extension
.luaspp<?lua= expression ?>In any case, your lua code should not include the ending tag
so
<?lua print('?>') ?>is malformed and should be rewritten by hand to<?lua print('?'..'>') ?>for exemple.