Added blockquote layout #42
Conversation
components/blockquote/Component.php
Outdated
| use Illuminate\View\Component; | ||
| use Whitecube\BemComponents\HasBemClasses; | ||
|
|
||
| class blockquote extends Component |
There was a problem hiding this comment.
Il faut une majuscule ici, non ?
components/blockquote/Layout.php
Outdated
| return [ | ||
| DataList::make() | ||
| ->row('Text', TextComponent::make($this->text)) | ||
| ->row('Author', TextComponent::make($this->author ?? '--')), |
There was a problem hiding this comment.
Le -- est la valeur par défaut si $this->author vaut null, donc pas besoin de le mettre.
components/blockquote/view.blade.php
Outdated
| <blockquote class="blockquote__quote"> | ||
| {{ $text }} | ||
| </blockquote> | ||
| @if($author) | ||
| <cite class="blockquote__author">{{ $author }}</cite> | ||
| @endif |
There was a problem hiding this comment.
D'après https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/blockquote ce sont des paragraphes qu'il faut mettre dans le contenu du blocquote. Du coup je te suggère simplement de passer le type de field à WYSIWYG, ça nous emmerdera moins par la suite.
Attention que <cite> ne sert pas à baliser l'auteur. C'est pour la source uniquement :
- https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/cite
- https://html.spec.whatwg.org/multipage/text-level-semantics.html#the-cite-element
The cite element represents the title of a work (e.g. a book, a paper, [...])
A person's name is not the title of a work [...] and the element must therefore not be used to mark up people's names.
Il semblerait plus adéquat d'utiliser figure + blockquote + figcaption :)
https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/figure#quotations
No description provided.