Implementing resolveUsing, displayUsing and fillUsing#235
Open
jeffreyzant wants to merge 3 commits intowhitecube:masterfrom
Open
Implementing resolveUsing, displayUsing and fillUsing#235jeffreyzant wants to merge 3 commits intowhitecube:masterfrom
jeffreyzant wants to merge 3 commits intowhitecube:masterfrom
Conversation
voidgraphics
requested changes
Dec 9, 2020
Member
voidgraphics
left a comment
voidgraphics
left a comment
There was a problem hiding this comment.
👍 Thank you for the PR. I would love @Nyratas to take a look at it before we approve it - but in the meantime, I have highlighted some quick fixes that would be needed if we were to merge it.
Author
|
I've got it fixed, let me know if there's anything else! |
|
@Nyratas Thanks for this awesome library. Can you please implement the optional callback resolver? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also mentioned in #224, see the updated docs for the usage. If there are any questions or wanted improvements feel free to let me know!