Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum fields option #266

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

samboylett
Copy link

@samboylett samboylett commented Mar 15, 2021

Adds the option to set a minimum number of fields. Will make the delete icon/button disappear if the number of fields is at or below the minimum.

Above minimum:
Screenshot 2021-03-15 at 15 13 23

At/below minimum:
Screenshot 2021-03-15 at 15 13 17

Also made it so the ordering icons aren't visible unless there are at least 2 layouts present:

Screenshot 2021-03-15 at 15 45 39

Screenshot 2021-03-15 at 15 45 50

And with a little refactoring moved some reactive data to computed properties

@samboylett samboylett marked this pull request as ready for review March 15, 2021 15:20
@voidgraphics
Copy link
Member

Hi @samboylett, thanks for the PR. It would be interesting to also add a php validation rule automatically when setting a minimum number of rows. What do you think?

@riptin
Copy link

riptin commented Jun 9, 2023

Please resolve this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants